Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove disabling of already-disabled rule #6013

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 2, 2016

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

test tools buffer

Description of change

require-buffer is only enabled in the lib directory. There is no
need to disable it in test.

@Trott Trott added buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Apr 2, 2016
@Trott Trott changed the title tools: remove require-buffer lint rule for tests tools: enable require-buffer lint rule for tests Apr 2, 2016
`require-buffer` is only enabled in the `lib` directory. There is no
need to disable it in `test`.
@Trott Trott changed the title tools: enable require-buffer lint rule for tests tools: remove disabling of already-disabled rule Apr 2, 2016
@bnoordhuis
Copy link
Member

LGTM

2 similar comments
@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Apr 2, 2016

LGTM

jasnell pushed a commit that referenced this pull request Apr 2, 2016
`require-buffer` is only enabled in the `lib` directory. There is no
need to disable it in `test`.

PR-URL: #6013
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

Landed in 8832be4

@jasnell jasnell closed this Apr 2, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
`require-buffer` is only enabled in the `lib` directory. There is no
need to disable it in `test`.

PR-URL: #6013
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins
Copy link
Contributor

@Trott lts?

@Trott
Copy link
Member Author

Trott commented Apr 11, 2016

@thealphanerd Yes.

MylesBorins pushed a commit that referenced this pull request May 3, 2016
`require-buffer` is only enabled in the `lib` directory. There is no
need to disable it in `test`.

PR-URL: #6013
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 6, 2016
`require-buffer` is only enabled in the `lib` directory. There is no
need to disable it in `test`.

PR-URL: #6013
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
`require-buffer` is only enabled in the `lib` directory. There is no
need to disable it in `test`.

PR-URL: #6013
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
@Trott Trott deleted the buffy branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants