Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: fix gzip member head/buffer boundary issue (backport of #5883) #5973

Closed
wants to merge 1 commit into from
Closed

zlib: fix gzip member head/buffer boundary issue (backport of #5883) #5973

wants to merge 1 commit into from

Commits on Apr 2, 2016

  1. zlib: fix gzip member head/buffer boundary issue 

    Make sure that, even if an `inflate()` call only sees the first
few bytes of a following gzip member, all members are decompressed
and part of the full output.

Adds tests for the special case that the first `inflate()` call
receives only the first few bytes of a second gzip member but
not the whole header (or even just the magic bytes).

This is a backport of nodejs#5883 and contains additional changes to
make sure that the behaviour on encountering trailing garbage
remains the same (namely to silently discard it if one full member
has already been decompressed).

 #PR-URL: nodejs#5883
 #Reviewed-By: Ben Noordhuis <[email protected]>
 #Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Apr 2, 2016
    Configuration menu
    Copy the full SHA
    172c991 View commit details
    Browse the repository at this point in the history