test: stdin is not always a net.Socket #5935

Fishrock123 · 2016-03-28T15:26:17Z

Pull Request check-list

Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
this change (including linting)?
Is the commit message formatted according to CONTRIBUTING.md?

Affected core subsystem(s)

test

Description of change

<-ing a file into stdin actually results in a fs.ReadStream, rather an a tty.ReadStream, and as such does not inherit from net.Socket, unlike the other possible stdin options:

node/lib/internal/process/stdio.js

Lines 54 to 57 in 293fd04

case 'FILE':

var fs = require('fs');

stdin = new fs.ReadStream(null, { fd: fd, autoClose: false });

break;

cc @Trott I think this should cover the known issue.

cjihrig · 2016-03-28T16:30:14Z

test/known_issues/test-stdin-is-always-net.socket.js

+const spawn = require('child_process').spawn;
+
+if (process.argv[2] === 'child') {
+  // Refs: https://github.com/nodejs/node/pull/5916


Can you move this comment up to line 2.

cjihrig · 2016-03-28T16:31:21Z

LGTM with a couple comments.

Fishrock123 · 2016-03-30T17:29:35Z

Hmmm, doing this reliably in a must-fail environment is quite tricky.

Fishrock123 · 2016-03-30T17:38:31Z

CI on windows: https://ci.nodejs.org/job/node-test-known-issues/2/ (That ci says to not run with all?)

Fishrock123 · 2016-03-31T16:27:44Z

@cjihrig LGTY now?

cjihrig · 2016-03-31T17:07:36Z

Yea, LGTM

`<`-ing a file into stdin actually results in a `fs.ReadStream`, rather than a `tty.ReadStream`, and as such does not inherit from net.Socket, unlike the other possible stdin options. Refs: nodejs#5916 PR-URL: nodejs#5935 Reviewed-By: Colin Ihrig <[email protected]>

cjihrig · 2016-03-31T18:21:14Z

@Fishrock123 is there a particular issue on the issue tracker that this maps to? I noticed you Refs'ed a PR. I've been adding the repro-exists label to the referenced issues, but I'm not not if that would apply to a PR.

phillipj · 2016-03-31T20:49:26Z

@Fishrock123 did this pass linting for you? I'm getting this locally:

➜ make lint
./node tools/eslint/bin/eslint.js benchmark lib src test tools/doc \
        tools/eslint-rules --rulesdir tools/eslint-rules

/Users/phillipj/node/test/known_issues/test-stdin-is-always-net.socket.js
  14:1  error  Line 14 exceeds the maximum line length of 80  max-len

✖ 1 problem (1 error, 0 warnings)

thefourtheye · 2016-03-31T21:00:03Z

#5980 Fixes the linter error

Refer: nodejs#5935 PR-URL: nodejs#5980 Reviewed-By: Jeremiah Senkpiel <[email protected]>

Refer: #5935 PR-URL: #5980 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Phillip Johnsen <[email protected]>

jasnell · 2016-04-01T03:00:04Z

Is this applicable to v4?

Fishrock123 · 2016-04-04T16:24:38Z

@jasnell do we put known-issue tests there? if so, yes this applies back as far as I can remember.

jasnell · 2016-04-04T16:31:42Z

Yep, we can port the known-issue tests back to v4 now

`<`-ing a file into stdin actually results in a `fs.ReadStream`, rather than a `tty.ReadStream`, and as such does not inherit from net.Socket, unlike the other possible stdin options. Refs: #5916 PR-URL: #5935 Reviewed-By: Colin Ihrig <[email protected]>

Refer: #5935 PR-URL: #5980 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Phillip Johnsen <[email protected]>

`<`-ing a file into stdin actually results in a `fs.ReadStream`, rather than a `tty.ReadStream`, and as such does not inherit from net.Socket, unlike the other possible stdin options. Refs: #5916 PR-URL: #5935 Reviewed-By: Colin Ihrig <[email protected]>

Refer: #5935 PR-URL: #5980 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Phillip Johnsen <[email protected]>

addaleax · 2018-05-18T15:21:54Z

@Fishrock123 I know this was a long, long time ago, but what exactly is the issue that this test is catching? It sounds like the underlying idea is that stdio streams should always inherit from net.Socket, but that isn’t really made explicit anywhere, is it?

Fishrock123 · 2018-05-18T17:36:28Z

@addaleax There was this thing at one point where sometimes stdin wasnt a net.Socket... I think this checks when stdin doesn't actually exist that it still makes a socket?

It was supposed to be a consistency check.

Edit:

It sounds like the underlying idea is that stdio streams should always inherit from net.Socket

Yes.

Fishrock123 added test Issues and PRs related to the tests. process Issues and PRs related to the process subsystem. labels Mar 28, 2016

Fishrock123 mentioned this pull request Mar 28, 2016

test: ensure existence of _handle property #5916

Closed

4 tasks

cjihrig reviewed Mar 28, 2016
View reviewed changes

mscdex added the known issue test label Mar 28, 2016

Fishrock123 force-pushed the known-issue-stdin-not-net.socket branch from f9486f0 to f384f83 Compare March 30, 2016 17:36

Fishrock123 force-pushed the known-issue-stdin-not-net.socket branch from f384f83 to d6c9f64 Compare March 31, 2016 18:11

Fishrock123 merged commit d6c9f64 into nodejs:master Mar 31, 2016

Fishrock123 mentioned this pull request Mar 31, 2016

test: fix offending max-len linter error #5980

Closed

2 tasks

thefourtheye added a commit to thefourtheye/io.js that referenced this pull request Mar 31, 2016

test: fix offending max-len linter error

d024316

Refer: nodejs#5935 PR-URL: nodejs#5980 Reviewed-By: Jeremiah Senkpiel <[email protected]>

thefourtheye added a commit that referenced this pull request Mar 31, 2016

test: fix offending max-len linter error

854f758

Refer: #5935 PR-URL: #5980 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Phillip Johnsen <[email protected]>

jasnell added the lts-watch-v4.x label Apr 4, 2016

MylesBorins pushed a commit that referenced this pull request Apr 5, 2016

test: fix offending max-len linter error

4f1fa2a

Refer: #5935 PR-URL: #5980 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Phillip Johnsen <[email protected]>

This was referenced Apr 5, 2016

V5.10.1 proposal #6059

Closed

V5.10.1 proposal #6060

Merged

MylesBorins pushed a commit that referenced this pull request Apr 11, 2016

test: fix offending max-len linter error

10fe79b

Refer: #5935 PR-URL: #5980 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Phillip Johnsen <[email protected]>

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Apr 11, 2016

MylesBorins mentioned this pull request Apr 11, 2016

V4.4.3 proposal #6149

Merged

addaleax added the known limitation Issues that are identified as known limitations. label May 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: stdin is not always a net.Socket #5935

test: stdin is not always a net.Socket #5935

Fishrock123 commented Mar 28, 2016

cjihrig Mar 28, 2016

cjihrig commented Mar 28, 2016

Fishrock123 commented Mar 30, 2016

Fishrock123 commented Mar 30, 2016

Fishrock123 commented Mar 31, 2016

cjihrig commented Mar 31, 2016

cjihrig commented Mar 31, 2016

phillipj commented Mar 31, 2016

thefourtheye commented Mar 31, 2016

jasnell commented Apr 1, 2016

Fishrock123 commented Apr 4, 2016

jasnell commented Apr 4, 2016

addaleax commented May 18, 2018

Fishrock123 commented May 18, 2018 •

edited

Loading

	case 'FILE':
	var fs = require('fs');
	stdin = new fs.ReadStream(null, { fd: fd, autoClose: false });
	break;

test: stdin is not always a net.Socket #5935

test: stdin is not always a net.Socket #5935

Conversation

Fishrock123 commented Mar 28, 2016

Pull Request check-list

Affected core subsystem(s)

Description of change

cjihrig Mar 28, 2016

Choose a reason for hiding this comment

cjihrig commented Mar 28, 2016

Fishrock123 commented Mar 30, 2016

Fishrock123 commented Mar 30, 2016

Fishrock123 commented Mar 31, 2016

cjihrig commented Mar 31, 2016

cjihrig commented Mar 31, 2016

phillipj commented Mar 31, 2016

thefourtheye commented Mar 31, 2016

jasnell commented Apr 1, 2016

Fishrock123 commented Apr 4, 2016

jasnell commented Apr 4, 2016

addaleax commented May 18, 2018

Fishrock123 commented May 18, 2018 • edited Loading

Fishrock123 commented May 18, 2018 •

edited

Loading