http: replace util._extend() with Object.create() #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`options` is never touched, so there's no need to make a copy. Anyways, a better alternative for making copies is to just `Object.create()` the object. An alternative solution is to not bother copying at all. This solves issues such as https://github.com/petkaantonov/urlparser/issues where the `options` object is created from a constructor.
|
-1 on |
Qard
pushed a commit
that referenced
this pull request
Jan 24, 2015
Alternative to #592. The `options` object is never overwritten, so making a copy is not necessary. This solves issues such as https://github.com/petkaantonov/urlparser/issues where the options object is created from a constructor. PR-URL: #593 Reviewed-By: Stephen Belanger <[email protected]>
|
the other one was merged anyways, which i preferred. 👍 |
brendanashworth
referenced
this pull request
May 8, 2015
This reverts commit 06cfff9. Reverted because it introduced a regression where (because options were modified in the later functionality) options.host and options.port would be overridden with values provided in other, supported ways. PR-URL: #1467 Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optionsis never touched, so there's no need to make a copy. Anyways, a better alternative for making copies is to justObject.create()the object. An alternative solution is to not bother copying at all.This solves issues such as https://github.com/petkaantonov/urlparser/issues where the
optionsobject is created from a constructor.