Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update fansworld-claudio username on README #5680

Conversation

claudiorodriguez
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

doc

Description of change

Had to change my username from fansworld-claudio to claudiorodriguez on short notice. Updating that on README.md. Sorry about any inconvenience.

Updating collaborator username: fansworld-claudio
changed to claudiorodriguez

PR-URL: nodejs#5680
@claudiorodriguez claudiorodriguez force-pushed the doc-update-fansworld-claudio-collaborator-username branch from f2f1c9e to f1bbd1d Compare March 13, 2016 07:03
@claudiorodriguez claudiorodriguez added the doc Issues and PRs related to the documentations. label Mar 13, 2016
@benjamingr
Copy link
Member

LGTM.

@rvagg
Copy link
Member

rvagg commented Mar 14, 2016

lgtm

@jbergstroem
Copy link
Member

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Mar 14, 2016

LGTM

jasnell pushed a commit that referenced this pull request Mar 14, 2016
Updating collaborator username: fansworld-claudio
changed to claudiorodriguez

PR-URL: #5680
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 14, 2016

Landed in e03c75b

@jasnell jasnell closed this Mar 14, 2016
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
Updating collaborator username: fansworld-claudio
changed to claudiorodriguez

PR-URL: #5680
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@evanlucas evanlucas mentioned this pull request Mar 14, 2016
rvagg pushed a commit that referenced this pull request Mar 16, 2016
Updating collaborator username: fansworld-claudio
changed to claudiorodriguez

PR-URL: #5680
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
Updating collaborator username: fansworld-claudio
changed to claudiorodriguez

PR-URL: #5680
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
Updating collaborator username: fansworld-claudio
changed to claudiorodriguez

PR-URL: #5680
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
Updating collaborator username: fansworld-claudio
changed to claudiorodriguez

PR-URL: #5680
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants