test: add batch of known issue tests

[cjihrig]

Pull Request check-list

Please make sure to review and check all of these items:

• Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
  this change (including linting)?
• Is the commit message formatted according to [CONTRIBUTING.md][0]?
• If this change fixes a bug (or a performance problem), is a regression
  test (or a benchmark) included?
• Is a documentation update included (if this change modifies
  existing APIs, or introduces new ones)?

Affected core subsystem(s)

test

Description of change

This commit adds tests for several known issues.

Refs: #1901
Refs: #728
Refs: #4778
Refs: #947
Refs: #2734

R=@Trott

[mscdex]

FWIW there is already a PR for the known test for #728 in #5649

[jasnell]

LGTM sans the duplicated #728 test.

[Trott]

LGTM if CI is happy (which means the tests pass linting). I don't mind going with this test for #728 and closing the PR I opened for that.

[Trott]

All of these tests appear to use the wrong path for common. Should be ../common rather than ./test/common.

[cjihrig]

Oops, I had been working on the tests in a different directory. Fixed now.

[cjihrig]

And make jslint passes.

[Trott]

I guess make test-known-issues passes too? Tangent: Should test and/or test-ci include test-known-issues so that we make sure we remove tests from there when the issues are fixed (especially if we fix them accidentally)?

[Trott]

(And, of course: Still LGTM!)

[cjihrig]

Should test and/or test-ci include test-known-issues so that we make sure we remove tests from there when the issues are fixed (especially if we fix them accidentally)?

I'm leaning toward no. I wanted this functionality mostly to help triage the issue tracker. I created the repro-exists label to add to known issues that have tests. If we accidentally fix something, I'd hate to see it cause any friction at all with a legitimate PR. That said, if others wanted to add this to test or test-ci, I wouldn't fight over it.

[cjihrig]

Landed in 10bc673. Thanks for the reviews.

[jasnell]

Marking this lts-watch but it depends on landing the original PR that adds this capability (can't recall the pr number off hand)

[rvagg]

+1 for LTS as with the original addition of this dir

[MylesBorins]

@jasnell the functionality was backported in #5785

landing into staging now