Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: drop --experimental-permission in favour of --permission #56240

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: drop --experimental-permission in favour of --permission #56240

wants to merge 1 commit into from

Conversation

RafaelGSS
Copy link
Member

Refs: #56201

@RafaelGSS RafaelGSS added semver-major PRs that contain breaking changes and should be released in the next major version. permission Issues and PRs related to the Permission Model labels Dec 12, 2024
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 12, 2024
@targos
Copy link
Member

targos commented Dec 12, 2024

Can you avoid using a flag name that doesn't exist in the commit message?

@RafaelGSS RafaelGSS changed the title src: drop --experimental-pm in favour of --permission src: drop --experimental-permission in favour of --permission Dec 12, 2024
@RafaelGSS RafaelGSS force-pushed the drop-experimental-from-permission-flag branch from 6ece60e to 6d7dfa8 Compare December 12, 2024 15:17
@RafaelGSS
Copy link
Member Author

RafaelGSS commented Dec 12, 2024 •
edited
Loading

Can you avoid using a flag name that doesn't exist in the commit message?

I think linter will complain, just updated

@RafaelGSS
Copy link
Member Author

Depends on: #56239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RafaelGSS @targos @jasnell @anonrig @marco-ippolito @mertcanaltin @nodejs-github-bot