test: increase spin for eventloop test on s390 #56228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Does the test still fail without increasing the spin time? I wonder if anything has changed since the test was marked flaky. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56228 +/- ##
=======================================
Coverage 88.54% 88.54%
=======================================
Files 657 657
Lines 190395 190395
Branches 36552 36555 +3
=======================================
+ Hits 168580 168581 +1
+ Misses 14993 14990 -3
- Partials 6822 6824 +2 |
|
@lpinca I had looked at the test code and nothing changed since the issue was opened. Here is a run on main - https://ci.nodejs.org/view/Stress/job/node-stress-single-test/550/ |
|
I was referring to the actual code being tested, but I see one failure in the stress test on main. |
lpinca
approved these changes
Dec 11, 2024
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Dec 12, 2024
marco-ippolito
approved these changes
Dec 13, 2024
marco-ippolito
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56228 ✔ Done loading data for nodejs/node/pull/56228 ----------------------------------- PR info ------------------------------------ Title test: increase spin for eventloop test on s390 (#56228) Author Michael Dawson <[email protected]> (@mhdawson) Branch mhdawson:perftest-390 -> nodejs:main Labels test, needs-ci Commits 1 - test: increase spin for eventloop test on s390 Committers 1 - Michael Dawson <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56228 Refs: https://github.com/nodejs/node/issues/41286 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56228 Refs: https://github.com/nodejs/node/issues/41286 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 11 Dec 2024 14:55:35 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/56228#pullrequestreview-2496638593 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56228#pullrequestreview-2500210441 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56228#pullrequestreview-2502278882 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-12-12T17:37:56Z: https://ci.nodejs.org/job/node-test-pull-request/64026/ - Querying data for job/node-test-pull-request/64026/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12337187281 |
|
This needs a rebase. |
It was excluded as it was failing intermittently. Likely that s390 was just so fast times were rounded down to 0. Increase the spin time on s390x only. Signed-off-by: Michael Dawson <[email protected]>
mhdawson
force-pushed
the
perftest-390
branch
from
f9562c9 to
6c7ffa1
Compare
|
Rebased |
github-actions
bot
removed
the
request-ci
mhdawson
added a commit
that referenced
this pull request
Dec 24, 2024
It was excluded as it was failing intermittently. Likely that s390 was just so fast times were rounded down to 0. Increase the spin time on s390x only. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #56228 Refs: #41286 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
|
Landed in be9dc2d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was excluded as it was failing intermittently. Likely that s390 was just so fast times were rounded down to 0.
Refs: #41286
Increase the spin time on s390x only.
Stress run of 1000 with no failures with this change - https://ci.nodejs.org/job/node-stress-single-test/nodes=rhel8-s390x/548/console