Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix update-undici script #56069

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

targos
Copy link
Member

@targos targos commented Nov 29, 2024

The build:node npm script now expects esbuild to be installed and
bin-linked.

Closes: #56061

The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: nodejs#56061
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 29, 2024
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 29, 2024
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/56069
✔  Done loading data for nodejs/node/pull/56069
----------------------------------- PR info ------------------------------------
Title      tools: fix update-undici script (#56069)
Author     Michaël Zasso <targos@protonmail.com> (@targos)
Branch     targos:fix-update-undici -> nodejs:main
Labels     tools, fast-track
Commits    1
 - tools: fix update-undici script
Committers 1
 - Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/56069
Fixes: https://github.com/nodejs/node/issues/56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56069
Fixes: https://github.com/nodejs/node/issues/56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 29 Nov 2024 07:16:14 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/56069#pullrequestreview-2469270582
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/56069#pullrequestreview-2469273722
   ✔  - Pietro Marchini (@pmarchini): https://github.com/nodejs/node/pull/56069#pullrequestreview-2469328031
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 46 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/12081654293

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit 61b077d into nodejs:main Nov 29, 2024
39 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 61b077d

targos added a commit that referenced this pull request Dec 2, 2024
The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: #56061
PR-URL: #56069
Fixes: #56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: nodejs#56061
PR-URL: nodejs#56069
Fixes: nodejs#56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: nodejs#56061
PR-URL: nodejs#56069
Fixes: nodejs#56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: nodejs#56061
PR-URL: nodejs#56069
Fixes: nodejs#56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: nodejs#56061
PR-URL: nodejs#56069
Fixes: nodejs#56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: #56061
PR-URL: #56069
Fixes: #56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: #56061
PR-URL: #56069
Fixes: #56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: #56061
PR-URL: #56069
Fixes: #56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95 pushed a commit that referenced this pull request Dec 18, 2024
The `build:node` npm script now expects esbuild to be installed and
bin-linked.

Closes: #56061
PR-URL: #56069
Fixes: #56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undici updates are broken
6 participants