-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix update-undici script #56069
Merged
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `build:node` npm script now expects esbuild to be installed and bin-linked. Closes: nodejs#56061
Review requested:
|
Fast-track has been requested by @targos. Please 👍 to approve. |
lpinca
approved these changes
Nov 29, 2024
LiviaMedeiros
approved these changes
Nov 29, 2024
pmarchini
approved these changes
Nov 29, 2024
targos
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 29, 2024
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Nov 29, 2024
Commit Queue failed- Loading data for nodejs/node/pull/56069 ✔ Done loading data for nodejs/node/pull/56069 ----------------------------------- PR info ------------------------------------ Title tools: fix update-undici script (#56069) Author Michaël Zasso <targos@protonmail.com> (@targos) Branch targos:fix-update-undici -> nodejs:main Labels tools, fast-track Commits 1 - tools: fix update-undici script Committers 1 - Michaël Zasso <targos@protonmail.com> PR-URL: https://github.com/nodejs/node/pull/56069 Fixes: https://github.com/nodejs/node/issues/56061 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56069 Fixes: https://github.com/nodejs/node/issues/56061 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 29 Nov 2024 07:16:14 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/56069#pullrequestreview-2469270582 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/56069#pullrequestreview-2469273722 ✔ - Pietro Marchini (@pmarchini): https://github.com/nodejs/node/pull/56069#pullrequestreview-2469328031 ℹ This PR is being fast-tracked ✘ This PR needs to wait 46 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12081654293 |
mcollina
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
mcollina
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Nov 29, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 29, 2024
Landed in 61b077d |
targos
added a commit
that referenced
this pull request
Dec 2, 2024
The `build:node` npm script now expects esbuild to be installed and bin-linked. Closes: #56061 PR-URL: #56069 Fixes: #56061 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
The `build:node` npm script now expects esbuild to be installed and bin-linked. Closes: nodejs#56061 PR-URL: nodejs#56069 Fixes: nodejs#56061 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
The `build:node` npm script now expects esbuild to be installed and bin-linked. Closes: nodejs#56061 PR-URL: nodejs#56069 Fixes: nodejs#56061 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
The `build:node` npm script now expects esbuild to be installed and bin-linked. Closes: nodejs#56061 PR-URL: nodejs#56069 Fixes: nodejs#56061 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
The `build:node` npm script now expects esbuild to be installed and bin-linked. Closes: nodejs#56061 PR-URL: nodejs#56069 Fixes: nodejs#56061 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced Dec 6, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
The `build:node` npm script now expects esbuild to be installed and bin-linked. Closes: #56061 PR-URL: #56069 Fixes: #56061 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
The `build:node` npm script now expects esbuild to be installed and bin-linked. Closes: #56061 PR-URL: #56069 Fixes: #56061 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
The `build:node` npm script now expects esbuild to be installed and bin-linked. Closes: #56061 PR-URL: #56069 Fixes: #56061 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
The `build:node` npm script now expects esbuild to be installed and bin-linked. Closes: #56061 PR-URL: #56069 Fixes: #56061 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fast-track
PRs that do not need to wait for 48 hours to land.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
build:node
npm script now expects esbuild to be installed andbin-linked.
Closes: #56061