Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: deflake test-esm-loader-hooks-inspect-brk #56050

Merged
merged 1 commit into from
Dec 19, 2024
Merged

test: deflake test-esm-loader-hooks-inspect-brk #56050

merged 1 commit into from
Dec 19, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 28, 2024

Refs: #54827
Refs: #51560

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 28, 2024
@lpinca
Copy link
Member Author

lpinca commented Nov 28, 2024

This should fix https://ci.nodejs.org/job/node-test-commit-plinux/56544/nodes=rhel8-ppc64le/testReport/junit/(root)/parallel/test_esm_loader_hooks_inspect_brk/

---
duration_ms: 15449.878
exitcode: 1
severity: fail
stack: |-
  [test] Connecting to a child Node process
  [test] Testing /json/list
  [err] Debugger listening on ws://127.0.0.1:39645/fd174c31-85ea-460b-8b5c-aad1caeddb9c
  [err] For help, see: https://nodejs.org/en/docs/inspector
  [err]
  [err] Debugger attached.
  [err]
  Timed out waiting for matching notification (Debugger.paused)
  1
...

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base (24a8662) to head (e83cba9).
Report is 153 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56050      +/-   ##
==========================================
- Coverage   87.97%   87.97%   -0.01%     
==========================================
  Files         656      656              
  Lines      188383   188383              
  Branches    35973    35976       +3     
==========================================
- Hits       165732   165726       -6     
- Misses      15821    15832      +11     
+ Partials     6830     6825       -5

see 30 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63742/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63752/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63764/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63768/

@lpinca
Copy link
Member Author

lpinca commented Dec 17, 2024 •
edited
Loading

@nodejs/testing @nodejs/loaders

aduh95
aduh95 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit rubber stampy, but LGTM nonetheless

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 990497c into nodejs:main Dec 19, 2024
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 990497c

@lpinca lpinca deleted the deflake/test-esm-loader-hooks-inspect-brk branch December 20, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpinca @nodejs-github-bot @aduh95