-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quic: more work on quic #55986
Closed
Closed
quic: more work on quic #55986
+1,088
−489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Nov 24, 2024
anonrig
approved these changes
Nov 24, 2024
jasnell
added
the
quic
Issues and PRs related to the QUIC implementation / HTTP/3.
label
Nov 24, 2024
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
get-quic-working-part1
branch
from
November 24, 2024 21:17
f434bb8
to
8761d63
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mcollina
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jasnell
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
needs-ci
PRs that need a full CI run.
labels
Nov 25, 2024
anonrig
approved these changes
Nov 25, 2024
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
get-quic-working-part1
branch
from
November 26, 2024 00:24
8761d63
to
93da5d7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Qard
approved these changes
Nov 26, 2024
jasnell
added a commit
that referenced
this pull request
Nov 28, 2024
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #55986 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Landed in 4cf6fab |
targos
pushed a commit
that referenced
this pull request
Dec 2, 2024
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #55986 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
github-actions bot
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#55986 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#55986 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#55986 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#55986 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#55986 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This was referenced Dec 6, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #55986 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #55986 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #55986 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #55986 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
lib / src
Issues and PRs related to general changes in the lib or src directory.
quic
Issues and PRs related to the QUIC implementation / HTTP/3.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #55971 which should land first. (this PR includes those commits currently)
Further implementation and refinement of the QUIC JS API