doc: improve GN build documentation a bit #55968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
joyeecheung
approved these changes
Nov 23, 2024
jasnell
approved these changes
Nov 23, 2024
RafaelGSS
approved these changes
Nov 23, 2024
lpinca
approved these changes
Nov 23, 2024
StefanStojanovic
approved these changes
Nov 25, 2024
codebytere
force-pushed
the
more-documentation-gn-build
branch
from
e0209f9
to
212b193
Compare
juanarbol
approved these changes
Nov 27, 2024
codebytere
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c6d3fdd |
targos
pushed a commit
that referenced
this pull request
Dec 2, 2024
PR-URL: #55968 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title. With my last few commits as well as some i've made upstream to
node-ci, the GN build now compiles on Windows:This adds some Windows-specific notes to documentation.