deps: upgrade npm in LTS to 2.14.21 in Node.js 0.12 LTS

[othiym23]

Pull Request check-list

Please make sure to review and check all of these items:

• Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
  this change (including linting)? (see below)
• Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

• deps

Description of change

Upgrades the v0.12 LTS branch to use npm@lts / npm@2.

Got one repeatable test failure, but am confident it's not related to this change:

/usr/bin/python tools/test.py --mode=release simple message
=== release test-chdir ===
Path: simple/test-chdir
fs.js:747
  return binding.mkdir(pathModule._makeLong(path),
                 ^
Error: EEXIST, file already exists '/Users/ogd/Documents/projects/npm/release-node/test/fixtures/weird 쎤쎫쎯 characters áâã'
    at Error (native)
    at Object.fs.mkdirSync (fs.js:747:18)
    at Object.<anonymous> (/Users/ogd/Documents/projects/npm/release-node/test/simple/test-chdir.js:34:4)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3
Command: out/Release/node /Users/ogd/Documents/projects/npm/release-node/test/simple/test-chdir.js
[00:19|%   5|+  42|-   1]: release test-child-process-send-utf8^C Interrupted
make: *** [test] Error 1

We've also confirmed that npm's tests run when run against Node 0.12 in Travis. It should also get a citgm run.

I tried to be conservative about what tags I applied, and apologize in advance if I misinterpreted the meanings of the ones that I set. This might also need lts-agenda, since I understand this will be discussed at this week's LTS meeting.

[email protected] includes the updated LICENSE which includes the removal of the potentially confusing web site and registry Terms of Use. v0.12 (also) doesn't have the license updating tool, so is there a best practice for updating the top-level LICENSE to reflect the changed npm license?

r: @thealphanerd
r: @Fishrock123

[othiym23]

(The test failure recurs if I manually clear out that file:

/usr/bin/python tools/test.py --mode=release simple message
=== release test-chdir ===
Path: simple/test-chdir
assert.js:86
  throw new assert.AssertionError({
        ^
AssertionError: false == true
    at Object.<anonymous> (/Users/ogd/Documents/projects/npm/release-node/test/simple/test-chdir.js:36:1)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3
Command: out/Release/node /Users/ogd/Documents/projects/npm/release-node/test/simple/test-chdir.js
[03:02|% 100|+ 814|-   1]: Done
make: *** [test] Error 1

)

[rvagg]

leave the LICENSE thing with me for now

[MylesBorins]

citgm: https://ci.nodejs.org/job/thealphanerd-smoker/108/

[MylesBorins]

the results are in from citgm

• build for ppcle-ubuntu1404 failed ~ @mhdawson
• tape was flaky on fedora which is unrelated to this change
• moment is failing on all the ubuntu boxes ~ https://ci.nodejs.org/job/thealphanerd-smoker/108/nodes=ubuntu1504-64/tapTestReport/smoker%2Ftest.tap-28/
  • it is worth noting this is the first time citgm has been run on v0.12. I'll file this with moment and try and figure out the problem,

OSX failed due to jenkins weirdness https://ci.nodejs.org/job/thealphanerd-smoker/108/nodes=osx1010/console

I'm going to test locally

[rvagg]

jenkins weirdness should be resolved now

[MylesBorins]

Latest run: https://ci.nodejs.org/job/thealphanerd-smoker/109/

edit: the moment failure we are seeing on ubuntu is being tracked up stream
moment/moment#3016

[mattjohnsonpint]

WRT the moment.js error, it's DST related, and should go away on its own by this Monday. We have a fix pending in a PR, but see no need to push a hotfix release for such a minor issue at this time.

[ChALkeR]

Could this be closed now?

[MylesBorins]

We have a newer version of npm in v0.12 now. closing