doc: add missing documentation for PerformanceObserver.prototype.takeRecords()
#55786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
Hi! Can you please amend your commit to follow the guidelines? It's a bit too long. |
Sure! |
skyclouds2001
force-pushed
the
fix-55779-PerformanceObserver-takeRecords
branch
from
d379b7a to
04c1d1f
Compare
|
Done! |
aduh95
reviewed
Nov 14, 2024
skyclouds2001
force-pushed
the
fix-55779-PerformanceObserver-takeRecords
branch
from
04c1d1f to
0624b37
Compare
skyclouds2001
force-pushed
the
fix-55779-PerformanceObserver-takeRecords
branch
from
0624b37 to
ab83e2c
Compare
jasnell
approved these changes
Nov 23, 2024
jazelly
approved these changes
Nov 24, 2024
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in b17a1fb |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55786 Fixes: nodejs#55779 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
PR-URL: #55786 Fixes: #55779 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Dec 6, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55786 Fixes: #55779 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55786 Fixes: #55779 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55786 Fixes: #55779 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR add missing documentation for
PerformanceObserver.prototype.takeRecords(), which landed in v16.0.0 withPerformanceObserver.supportedEntryTypesconfirmed by the release v16.0.0 and impl PR #37136
see also mdn documentation and specification
Fixes: #55779