fix(build): uninstall support AIX 7.1 #55438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
|
Can you update the commit message to be prefixed with "build" rather than "fix(build)"? |
richardlau
approved these changes
Oct 18, 2024
Sorry, I don't have an IBM i machine yet. |
Signed-off-by: Cloorc <[email protected]>
Yes, updated. Please have a look! |
richardlau
approved these changes
Oct 18, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
added
the
author ready
abmusse
approved these changes
Oct 21, 2024
github-actions
bot
removed
the
request-ci
richardlau
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55438 ✔ Done loading data for nodejs/node/pull/55438 ----------------------------------- PR info ------------------------------------ Title fix(build): uninstall support AIX 7.1 (#55438) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cloorc:main -> nodejs:main Labels build, aix, python, author ready, needs-ci Commits 1 - build: fix uninstall script for AIX 7.1 Committers 1 - Cloorc <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55438 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Abdirahim Musse <[email protected]> Reviewed-By: Michael Dawson <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55438 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Abdirahim Musse <[email protected]> Reviewed-By: Michael Dawson <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 18 Oct 2024 03:20:11 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/55438#pullrequestreview-2378988172 ✔ - Abdirahim Musse (@abmusse): https://github.com/nodejs/node/pull/55438#pullrequestreview-2382538473 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/55438#pullrequestreview-2382544505 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-10-21T15:55:54Z: https://ci.nodejs.org/job/node-test-pull-request/63234/ - Querying data for job/node-test-pull-request/63234/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11445714148 |
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in fed28bf |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Cloorc <[email protected]> PR-URL: #55438 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Abdirahim Musse <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Signed-off-by: Cloorc <[email protected]> PR-URL: nodejs#55438 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Abdirahim Musse <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Cloorc <[email protected]> PR-URL: nodejs#55438 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Abdirahim Musse <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Cloorc <[email protected]> PR-URL: #55438 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Abdirahim Musse <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #55437 , please have a look!