crypto,tls: remove SSLv2 support #5536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
tls
| @@ -1093,13 +1093,19 @@ | |||
| 'L_ENDIAN', | |||
| 'PURIFY', | |||
| '_REENTRANT', | |||
|
|
|||
| 'OPENSSL_NO_SSL2', | |||
| # Heartbeat is a TLS extension, that couldn't be turned off or | |||
| # asked to be not advertised. Unfortunately this is unacceptable for | |||
| # Microsoft's IIS, which seems to be ignoring whole ClientHello after | |||
| # seeing this extension. | |||
| 'OPENSSL_NO_HEARTBEATS', | |||
|
lgtm pending CI, which I've asked for again: https://ci.nodejs.org/job/node-test-pull-request/1825/ @bnoordhuis there's a "CERTIFY_SAFE" checkbox (hoop) you have to jump through now to get it to go. |
Remove support for SSLv2 because of DROWN (CVE-2016-0800). Use of the `--enable-ssl2` flag is now an error; node will print an error message and exit. PR-URL: nodejs#5536 Reviewed-By: Rod Vagg <[email protected]>
bnoordhuis
force-pushed
the
v0.12-remove-sslv2
branch
from
00ff090
to
93ffe76
Compare
rvagg
pushed a commit
that referenced
this pull request
Mar 3, 2016
Remove support for SSLv2 because of DROWN (CVE-2016-0800). Use of the `--enable-ssl2` flag is now an error; node will print an error message and exit. PR-URL: #5536 Reviewed-By: Rod Vagg <[email protected]>
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
Remove support for SSLv2 because of DROWN (CVE-2016-0800). Use of the `--enable-ssl2` flag is now an error; node will print an error message and exit. PR-URL: nodejs/node#5536 Reviewed-By: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@rvagg and @indutny for the clienthello changes.
CI: https://ci.nodejs.org/job/node-test-pull-request/1822/