test: add a place for reproducing known bugs #5528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh nice... I have some concerns about maintainability of this but generally LGTM |
| @@ -192,6 +192,9 @@ test-internet: all | |||
| test-debugger: all | |||
| $(PYTHON) tools/test.py debugger | |||
|
|
|||
| test-bugs: all | |||
There was a problem hiding this comment.
instead of bugs, maybe name the folder and make step: broken
There was a problem hiding this comment.
To me, broken makes it sound like a place where we put tests that are broken, rather than a place where we have good tests that are failing because of bugs in the main code base. I prefer test-bugs or even test-known-issues.
There was a problem hiding this comment.
I like test-known-issues. @geek are you cool with that?
|
LGTM |
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail.
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: nodejs#548
|
Added the vcbuild piece. @Trott care to sign off on this? EDIT: Also renamed bugs to known-issues. |
|
LGTM if CI is green. |
|
Only failure is the ARM machine that appeared to be offline for several a number of CI runs. |
cjihrig
added a commit
that referenced
this pull request
Mar 4, 2016
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]>
cjihrig
added a commit
that referenced
this pull request
Mar 4, 2016
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]>
4 tasks
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
This seems like the kind of thing useful to backport. @cjihrig do you agree? |
|
I think it would be useful, but could be tricky to manage. |
|
hmm... not so sure about this one. @nodejs/lts ... thoughts? |
|
I would think you would want to put this in LTS. You're going to want the bug fixes for these things in LTS and not having the tests there just increases the friction when you go to land the bug fixes. It's just a directory of tests that don't get run. |
|
Agreed in principle, but there will be a bit of a maintenance burden as things get fixed in one branch but not others. I do see how it's useful tho and definitely wouldn't -1 it |
|
I think it's a +1 from me, reflecting on the difficulty we have with the 0.10 and 0.12 test suite, what we have on master is only going to get better and having this in v4 will help it as we get toward EOL to understand more about the delta and the state of the code. I also imagine that there will be a section of users who will be interested in this kind of information on v4 when contributing because that's the only branch they care about (we see this already on 0.10 and 0.12). |
|
so this does not land cleanly on |
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Mar 18, 2016
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 PR-URL: nodejs#5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]> Conflicts: tools/test.py
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Mar 18, 2016
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: nodejs#548 PR-URL: nodejs#5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Closed
|
Backport in #5785 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]> Conflicts: tools/test.py
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]> Conflicts: tools/test.py
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: nodejs/testing#18 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]> Conflicts: tools/test.py
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: #548 Backport-URL: #5785 PR-URL: #5528 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Wyatt Preul <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
test
Description of change
This PR is a proof of concept related to nodejs/testing#18. The point is to create a place to track the state of current known bugs, with a single command to verify that they still exist (the issue tracker has proven to be a difficult way to manage this).
There are currently a few hundred open issues, so I only bothered to port one bug reproduction. I also need to add
make test-bugsto vcbuild for Windows. If this can get in, I'll work to create more reproductions.