Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: report unfinished TLA in ambiguous modules #54980

Merged
merged 2 commits into from
Sep 19, 2024
Merged

module: report unfinished TLA in ambiguous modules #54980

merged 2 commits into from
Sep 19, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 17, 2024

Fixes: #54931

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (d2a4f92) to head (2ee5df9).
Report is 510 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54980      +/-   ##
==========================================
- Coverage   88.07%   88.06%   -0.01%     
==========================================
  Files         652      652              
  Lines      183546   183546              
  Branches    35859    35862       +3     
==========================================
- Hits       161649   161639      -10     
+ Misses      15147    15145       -2     
- Partials     6750     6762      +12
Files with missing lines Coverage Δ
lib/internal/modules/cjs/loader.js 96.19% <100.00%> (ø)

... and 32 files with indirect coverage changes

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62508/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit be4babb into nodejs:main Sep 19, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in be4babb

@aduh95 aduh95 deleted the unfinished-tla-ambiguous-files branch September 19, 2024 10:41
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Oct 1, 2024
@aduh95 @joyeecheung
module: report unfinished TLA in ambiguous modules
3dd9c34 
PR-URL: nodejs#54980
Fixes: nodejs#54931
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Oct 1, 2024
Closed
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95 @targos
module: report unfinished TLA in ambiguous modules
1d16976 
PR-URL: #54980
Fixes: #54931
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@aduh95 @louwers
module: report unfinished TLA in ambiguous modules
a6915e9 
PR-URL: nodejs#54980
Fixes: nodejs#54931
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@marco-ippolito marco-ippolito added the backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@aduh95 @tpoisseau
module: report unfinished TLA in ambiguous modules
52d0dec 
PR-URL: nodejs#54980
Fixes: nodejs#54931
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

detect-module: Typeless module syntax detection does not report unsettled top-level await
5 participants
@aduh95 @nodejs-github-bot @targos @joyeecheung @marco-ippolito