Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: use const with early return for path #54959

Merged
merged 1 commit into from
Sep 18, 2024
Merged

os: use const with early return for path #54959

merged 1 commit into from
Sep 18, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 16, 2024

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem. labels Sep 16, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (53ede87) to head (4d93f35).
Report is 517 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54959      +/-   ##
==========================================
- Coverage   88.07%   88.06%   -0.01%     
==========================================
  Files         652      652              
  Lines      183542   183543       +1     
  Branches    35862    35858       -4     
==========================================
- Hits       161653   161639      -14     
- Misses      15144    15154      +10     
- Partials     6745     6750       +5
Files with missing lines Coverage Δ
lib/os.js 97.35% <100.00%> (+<0.01%) ⬆️

... and 24 files with indirect coverage changes

@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62477/

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 16, 2024
@trivikr trivikr self-assigned this Sep 16, 2024
@anonrig
Copy link
Member

anonrig commented Sep 17, 2024

You beat me to it. Thank you!

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2024
@nodejs-github-bot nodejs-github-bot merged commit 87e7aeb into nodejs:main Sep 18, 2024
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 87e7aeb

@trivikr trivikr deleted the tmpdir-use-const-early-return branch September 18, 2024 03:31
targos pushed a commit that referenced this pull request Oct 4, 2024
@trivikr @targos
os: use const with early return for path
3300d59 
PR-URL: #54959
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@trivikr @louwers
os: use const with early return for path
6d7b248 
PR-URL: nodejs#54959
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@trivikr @tpoisseau
os: use const with early return for path
a70ecbf 
PR-URL: nodejs#54959
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees

@trivikr trivikr

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@trivikr @nodejs-github-bot @anonrig @lpinca @jakecastelli @atlowChemi @marco-ippolito