-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove duplicate skip AIX #54917
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
iwuliz:remove-unnecessary-skip-aix
Sep 15, 2024
Merged
test: remove duplicate skip AIX #54917
nodejs-github-bot
merged 1 commit into
nodejs:main
from
iwuliz:remove-unnecessary-skip-aix
Sep 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Sep 13, 2024
lpinca
approved these changes
Sep 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54917 +/- ##
=======================================
Coverage 88.04% 88.05%
=======================================
Files 651 651
Lines 183409 183409
Branches 35828 35823 -5
=======================================
+ Hits 161487 161500 +13
+ Misses 15174 15163 -11
+ Partials 6748 6746 -2 |
richardlau
approved these changes
Sep 13, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 13, 2024
meixg
approved these changes
Sep 13, 2024
lpinca
added
commit-queue
Add this label to land a pull request using GitHub Actions.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Sep 13, 2024
jakecastelli
approved these changes
Sep 14, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 15, 2024
Landed in 6db320a |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
PR-URL: #54917 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
PR-URL: #54917 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
PR-URL: #54917 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
PR-URL: #54917 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
targos
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
Sep 22, 2024
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54917 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54917 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Xuguang Mei <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip AIX is already defined on the top, so the
{ skip: common.isAIX }
is duplicated.