Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove duplicate skip AIX #54917

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

iwuliz
Copy link
Contributor

@iwuliz iwuliz commented Sep 13, 2024

Skip AIX is already defined on the top, so the { skip: common.isAIX } is duplicated.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (e21984b) to head (9d1a59d).
Report is 134 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #54917   +/-   ##
=======================================
  Coverage   88.04%   88.05%           
=======================================
  Files         651      651           
  Lines      183409   183409           
  Branches    35828    35823    -5     
=======================================
+ Hits       161487   161500   +13     
+ Misses      15174    15163   -11     
+ Partials     6748     6746    -2     

see 25 files with indirect coverage changes

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2024
@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6db320a into nodejs:main Sep 15, 2024
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6db320a

RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
PR-URL: #54917
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
PR-URL: #54917
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@iwuliz iwuliz deleted the remove-unnecessary-skip-aix branch September 17, 2024 00:13
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
PR-URL: #54917
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
PR-URL: #54917
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
PR-URL: nodejs#54917
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
PR-URL: nodejs#54917
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants