test: check typescript loader

[marco-ippolito]

Refs: #54645

[nodejs-github-bot]

Review requested:

• @nodejs/typescript

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61716/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (48c75bc) to head (ec65297).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54657      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         657      657              
  Lines      190395   190395              
  Branches    36552    36549       -3     
==========================================
- Hits       168580   168567      -13     
- Misses      14993    14996       +3     
- Partials     6822     6832      +10     

see 33 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61728/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61733/

[avivkeller]

FWIW new information has come to light in that issue and I don't think this fixes it.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61736/

[marco-ippolito]

FWIW new information has come to light in that issue and I don't think this fixes it.

Im checking if I can reproduce on the CI since I dont have a arm64 windows machine

[avivkeller]

I didn't know the CI even had that machine, cool!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/61790/

[avivkeller]

Windows ARM64 failure:

    ✖ execute a TypeScript loader and a .ts file (470.5079ms)
      AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Hello, TypeScript!/. Input:
      
      ''
      
          at TestContext.<anonymous> (file:///d:/workspace/node-test-binary-windows-js-suites/node/test/es-module/test-typescript.mjs:337:3)
          at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
          at async Test.run (node:internal/test_runner/test:888:9)
          at async Test.processPendingSubtests (node:internal/test_runner/test:584:7) {
        generatedMessage: true,
        code: 'ERR_ASSERTION',
        actual: '',
        expected: /Hello, TypeScript!/,
        operator: 'match'
      }
    
    ✖ execute a TypeScript loader and a .js file (444.2561ms)
      AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Hello, TypeScript!/. Input:
      
      ''
      
          at TestContext.<anonymous> (file:///d:/workspace/node-test-binary-windows-js-suites/node/test/es-module/test-typescript.mjs:350:3)
          at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
          at async Test.run (node:internal/test_runner/test:888:9)
          at async Test.processPendingSubtests (node:internal/test_runner/test:584:7) {
        generatedMessage: true,
        code: 'ERR_ASSERTION',
        actual: '',
        expected: /Hello, TypeScript!/,
        operator: 'match'
      }
    
    ℹ tests 29
    ℹ suites 0
    ℹ pass 27
    ℹ fail 2
    ℹ cancelled 0
    ℹ skipped 0
    ℹ todo 0
    ℹ duration_ms 10360.1598
    
    ✖ failing tests:
    
    test at test\es-module\test-typescript.mjs:328:1
    ✖ execute a TypeScript loader and a .ts file (470.5079ms)
      AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Hello, TypeScript!/. Input:
      
      ''
      
          at TestContext.<anonymous> (file:///d:/workspace/node-test-binary-windows-js-suites/node/test/es-module/test-typescript.mjs:337:3)
          at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
          at async Test.run (node:internal/test_runner/test:888:9)
          at async Test.processPendingSubtests (node:internal/test_runner/test:584:7) {
        generatedMessage: true,
        code: 'ERR_ASSERTION',
        actual: '',
        expected: /Hello, TypeScript!/,
        operator: 'match'
      }
    
    test at test\es-module\test-typescript.mjs:341:1
    ✖ execute a TypeScript loader and a .js file (444.2561ms)
      AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Hello, TypeScript!/. Input:
      
      ''
      
          at TestContext.<anonymous> (file:///d:/workspace/node-test-binary-windows-js-suites/node/test/es-module/test-typescript.mjs:350:3)
          at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
          at async Test.run (node:internal/test_runner/test:888:9)
          at async Test.processPendingSubtests (node:internal/test_runner/test:584:7) {
        generatedMessage: true,
        code: 'ERR_ASSERTION',
        actual: '',
        expected: /Hello, TypeScript!/,
        operator: 'match'
      }

(Yay, because we can repro the issue)

[marco-ippolito]

Yay so yes we got the repro now we have to wait for swc + amaro update

[legendecas]

It seems GitHub Action doesn't provide an arm64 windows environment and we have to rely on the jenkins job to cover this environment (and thus not being able to test this in nodejs/amaro unless setting up a jenkins job on that repo).

[avivkeller]

It seems GitHub Action doesn't provide an arm64 windows environment

According to https://docs.github.com/en/enterprise-cloud@latest/actions/using-github-hosted-runners/using-larger-runners/about-larger-runners#specifications-for-general-larger-runners, Github does have (in beta) these runners. But it appears to be a whole long process to set one up.

[targos]

Unfortunately, GitHub was not able to give us free access to large runners.

[avivkeller]

FWIW Github just announced this a few hours ago: https://github.blog/changelog/2024-09-03-github-actions-arm64-linux-and-windows-runners-are-now-generally-available/

[marco-ippolito]

Rebased, lets see if newer swc version have the same problem

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63097/

[marco-ippolito]

I got a Windows Arm64 VM on azure 💀 lets see if I can fix this bug

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64179/

[marco-ippolito]

wait what its green

[nodejs-github-bot]

Landed in 56d5865