Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine method rsa #5463

Merged
merged 2 commits into from
Feb 27, 2016
Merged

Engine method rsa #5463

merged 2 commits into from
Feb 27, 2016

Conversation

sam-github
Copy link
Contributor 

ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled
in the documentation, both should be ..._METHS.

constants.ENGINE_METHOD_RSA was documented, but not implemented.

This is semver-minor I guess, it introduces a new constant, albeit one that was documented to already exist.

@sam-github sam-github added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. semver-minor PRs that contain new features and should be released in the next minor version. labels Feb 27, 2016
@sam-github
Copy link
Contributor Author

/to @indutny

@indutny
Copy link
Member

indutny commented Feb 27, 2016

LGTM, though, I would land documentation fix separately to backport it to LTS.

@sam-github
Copy link
Contributor Author

@indutny Thanks. The doc change is a separate commit from the new crypto constant, so they can be cherry-picked independently.

@sam-github
constants: define ENGINE_METHOD_RSA
292033b 
constants.ENGINE_METHOD_RSA was documented, but not implemented.

PR-URL: nodejs#5463
Reviewed-By: Fedor Indutny <[email protected]>
@sam-github
doc: correct name of engine methods
513133c 
ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled
in the documentation, both should be ..._METHS.

PR-URL: nodejs#5463
Reviewed-By: Fedor Indutny <[email protected]>
@sam-github sam-github merged commit 513133c into nodejs:master Feb 27, 2016
@sam-github sam-github deleted the engine-method-rsa branch February 27, 2016 03:49
@sam-github
Copy link
Contributor Author

@indutny Hm, I hope I didn't close that too fast... it seemed trivial enough that your OK would be sufficient, I can't imagine any debate.

@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
Merged
5 tasks
@jasnell
Copy link
Member

jasnell commented Mar 2, 2016

Looks good, good catch on this. I'll mark this lts-watch with the caveat that only 513133c would be backported. /cc @thealphanerd

@sam-github
Copy link
Contributor Author

For my future reference: does it work better with the tracking machinery that entire PRs are either backportable or not, or is it sufficient that standalone commits are back-portable or not?

@jasnell @Fishrock123

@jasnell
Copy link
Member

jasnell commented Mar 7, 2016

Generally full PRs as the tools that pull this stuff out use the PR reference as opposed to the individual commit reference. What would likely be easiest is having a new PR that contains just the backported commit opened against v4.x-staging.

@Fishrock123 Fishrock123 mentioned this pull request Mar 8, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
@sam-github @Fishrock123
constants: define ENGINE_METHOD_RSA
a161549 
constants.ENGINE_METHOD_RSA was documented, but not implemented.

PR-URL: #5463
Reviewed-By: Fedor Indutny <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
@sam-github @Fishrock123
doc: correct name of engine methods
dd6bf80 
ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled
in the documentation, both should be ..._METHS.

PR-URL: #5463
Reviewed-By: Fedor Indutny <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
@sam-github @Fishrock123
constants: define ENGINE_METHOD_RSA
9db827c 
constants.ENGINE_METHOD_RSA was documented, but not implemented.

PR-URL: #5463
Reviewed-By: Fedor Indutny <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Mar 8, 2016
@sam-github @Fishrock123
doc: correct name of engine methods
b54a26f 
ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled
in the documentation, both should be ..._METHS.

PR-URL: #5463
Reviewed-By: Fedor Indutny <[email protected]>
Fishrock123 added a commit that referenced this pull request Mar 8, 2016
@Fishrock123
2016-03-08, Version 5.8.0 (Stable)
fc13773 
Notable changes:

* child_process: “send()” now accepts an options parameter (cjihrig)
#5283
  - Currently the only option is “keepOpen”, which keeps the underlying
socket open after the message is sent.
* constants: “ENGINE_METHOD_RSA” is now correctly exposed (Sam Roberts)
#5463
* Fixed two regressions which originated in v5.7.0:
  - http: Errors inside of http client callbacks now propagate
correctly (Trevor Norris) #5591
  - path: Fixed normalization of absolute paths (Evan Lucas)
#5589
* repl: “start()” no longer requires an options parameter (cjihrig)
#5388
* util: Improved “format()” performance 50-300% (Evan Lucas)
#5360

PR-URL: #5559
Fishrock123 added a commit to Fishrock123/node that referenced this pull request Mar 9, 2016
@Fishrock123
2016-03-08, Version 5.8.0 (Stable)
3c84752 
Notable changes:

* child_process: “send()” now accepts an options parameter (cjihrig)
nodejs#5283
- Currently the only option is “keepOpen”, which keeps the underlying
socket open after the message is sent.
* constants: “ENGINE_METHOD_RSA” is now correctly exposed (Sam Roberts)
nodejs#5463
* Fixed two regressions which originated in v5.7.0:
  - http: Errors inside of http client callbacks now propagate
correctly (Trevor Norris) nodejs#5591
  - path: Fixed normalization of absolute paths (Evan Lucas)
nodejs#5589
* repl: “start()” no longer requires an options parameter (cjihrig)
nodejs#5388
* util: Improved “format()” performance 50-300% (Evan Lucas)
nodejs#5360

PR-URL: nodejs#5559
@sam-github
Copy link
Contributor Author

What would likely be easiest is having a new PR that contains just the backported commit opened against v4.x-staging.

@jasnell so do you want me to do that, or is that a "next time" comment?

@jasnell
Copy link
Member

jasnell commented Mar 11, 2016

If you're able and willing to :)
On Mar 10, 2016 8:42 PM, "Sam Roberts" [email protected] wrote:

What would likely be easiest is having a new PR that contains just the
backported commit opened against v4.x-staging.

@jasnell https://github.com/jasnell so do you want me to do that, or is
that a "next time" comment?

—
Reply to this email directly or view it on GitHub
#5463 (comment).

@sam-github
Copy link
Contributor Author

@thealphanerd so, you want me to PR just f80c1c4 against v4.x?

@sam-github
Copy link
Contributor Author

@MylesBorins both these commits should land on v4.x

@sam-github
Copy link
Contributor Author

Ah, I see. The API docs were renamed from .markdown to .md. Not so clear on why that was worth the price.

backport #11002

sam-github added a commit to sam-github/node that referenced this pull request Feb 22, 2017
@sam-github
constants: define ENGINE_METHOD_RSA
6f92c50 
constants.ENGINE_METHOD_RSA was documented, but not implemented.

PR-URL: nodejs#5463
Reviewed-By: Fedor Indutny <[email protected]>
sam-github added a commit to sam-github/node that referenced this pull request Feb 22, 2017
@sam-github
doc: correct name of engine methods
ff68a44 
ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled
in the documentation, both should be ..._METHS.

PR-URL: nodejs#5463
Reviewed-By: Fedor Indutny <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 3, 2017
@sam-github @jasnell
constants: define ENGINE_METHOD_RSA
94964d0 
Original Commit Message:
  constants.ENGINE_METHOD_RSA was documented, but not implemented.

  PR-URL: #5463
  Reviewed-By: Fedor Indutny <[email protected]>

Backport-Of: #5463
PR-URL: #11002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Mar 3, 2017
@sam-github @jasnell
doc: correct name of engine methods
98d6b3f 
Original Commit Message:
  ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled
  in the documentation, both should be ..._METHS.

  PR-URL: #5463
  Reviewed-By: Fedor Indutny <[email protected]>

Backport-Of: #5463
PR-URL: #11002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2017
@sam-github @MylesBorins
constants: define ENGINE_METHOD_RSA
e53154a 
Original Commit Message:
  constants.ENGINE_METHOD_RSA was documented, but not implemented.

  PR-URL: #5463
  Reviewed-By: Fedor Indutny <[email protected]>

Backport-Of: #5463
PR-URL: #11002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2017
@sam-github @MylesBorins
doc: correct name of engine methods
8087825 
Original Commit Message:
  ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled
  in the documentation, both should be ..._METHS.

  PR-URL: #5463
  Reviewed-By: Fedor Indutny <[email protected]>

Backport-Of: #5463
PR-URL: #11002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 22, 2017
@sam-github @MylesBorins
constants: define ENGINE_METHOD_RSA
7ca1314 
Original Commit Message:
  constants.ENGINE_METHOD_RSA was documented, but not implemented.

  PR-URL: #5463
  Reviewed-By: Fedor Indutny <[email protected]>

Backport-Of: #5463
PR-URL: #11002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 22, 2017
@sam-github @MylesBorins
doc: correct name of engine methods
5af65b2 
Original Commit Message:
  ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled
  in the documentation, both should be ..._METHS.

  PR-URL: #5463
  Reviewed-By: Fedor Indutny <[email protected]>

Backport-Of: #5463
PR-URL: #11002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 4, 2017
@sam-github @MylesBorins
constants: define ENGINE_METHOD_RSA
951121f 
Original Commit Message:
  constants.ENGINE_METHOD_RSA was documented, but not implemented.

  PR-URL: #5463
  Reviewed-By: Fedor Indutny <[email protected]>

Backport-Of: #5463
PR-URL: #11002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 4, 2017
@sam-github @MylesBorins
doc: correct name of engine methods
6ac53f1 
Original Commit Message:
  ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled
  in the documentation, both should be ..._METHS.

  PR-URL: #5463
  Reviewed-By: Fedor Indutny <[email protected]>

Backport-Of: #5463
PR-URL: #11002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 1, 2017
@sam-github @Trott
constants: define ENGINE_METHOD_RSA
9e97dbe 
Original Commit Message:
  constants.ENGINE_METHOD_RSA was documented, but not implemented.

  PR-URL: nodejs#5463
  Reviewed-By: Fedor Indutny <[email protected]>

Backport-Of: nodejs#5463
PR-URL: nodejs#11002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 1, 2017
@sam-github @Trott
doc: correct name of engine methods
0cd4c0d 
Original Commit Message:
  ENGINE_METHOD_PKEY_METH and ENGINE_METHOD_PKEY_ASN1_METH are misspelled
  in the documentation, both should be ..._METHS.

  PR-URL: nodejs#5463
  Reviewed-By: Fedor Indutny <[email protected]>

Backport-Of: nodejs#5463
PR-URL: nodejs#11002
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sam-github @indutny @jasnell @MylesBorins