vm: add vm proto property lookup test #54606
Merged
+207
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
legendecas
force-pushed
the
vm/test-in-operator
branch
from
0b0d539
to
b3c170b
Compare
Add more test coverage on vm prototype properties lookup with `in` operator and property access.
legendecas
force-pushed
the
vm/test-in-operator
branch
from
b3c170b
to
cfbd885
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54606 +/- ##
==========================================
- Coverage 87.34% 87.33% -0.01%
==========================================
Files 649 649
Lines 182562 182562
Branches 35023 35025 +2
==========================================
- Hits 159451 159447 -4
+ Misses 16396 16382 -14
- Partials 6715 6733 +18 |
targos
approved these changes
Aug 28, 2024
github-actions
bot
removed
the
request-ci
joyeecheung
approved these changes
Aug 29, 2024
jasnell
approved these changes
Aug 31, 2024
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 70de19e |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
Add more test coverage on vm prototype properties lookup with `in` operator and property access. PR-URL: #54606 Refs: #54436 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
Add more test coverage on vm prototype properties lookup with `in` operator and property access. PR-URL: nodejs#54606 Refs: nodejs#54436 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Add more test coverage on vm prototype properties lookup with `in` operator and property access. PR-URL: nodejs#54606 Refs: nodejs#54436 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more test coverage on vm prototype properties lookup with
inoperator and property access.Refs: #54436
/cc @nodejs/vm