-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v22.x] Backport: "module: add --experimental-transform-types flag" #54373
[v22.x] Backport: "module: add --experimental-transform-types flag" #54373
Conversation
PR-URL: nodejs#54283 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
Review requested:
|
I was planning to land it on the next 22 proposal, but CI seems flaky. I will need to update v22.x-staging and then you'll need to rebase on top of it. If we get a green CI tomorrow (Monday 19) I can cherry-pick it. |
It seems a Macos machine disk is full, thats the failure |
@RafaelGSS since I saw in the proposal we unflagged detect module, the original commit should land cleanly |
PR-URL: #54283
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Zeyu "Alex" Yang [email protected]
Reviewed-By: Chengzhong Wu [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Paolo Insogna [email protected]
This backport simply adds the imply of
--experimental-detect-module
. @targos