Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix unhandled errors in webstream adapters #54206

Merged
merged 1 commit into from
Aug 6, 2024

Commits on Aug 4, 2024

  1. lib: fix unhandled errors in webstream adapters

    WebStream's Readable controller does not tolerate `.close()` being
    called after an `error`. However, when wrapping a Node's Readable stream
    it is possible that the sequence of events leads to `finished()`'s
    callback being invoked after such `error`.
    
    In order to handle this, in this change we call the `finished()` handler
    earlier when controller is canceled, and always handle this as an error
    case.
    
    Fix: nodejs#54205
    indutny committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    c8494a9 View commit details
    Browse the repository at this point in the history