module: remove outdated comment #54118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
esm
juanarbol
approved these changes
Jul 30, 2024
aduh95
approved these changes
Jul 30, 2024
aduh95
added
author ready
lpinca
approved these changes
Jul 30, 2024
targos
added
the
commit-queue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54118 +/- ##
==========================================
+ Coverage 87.04% 87.07% +0.02%
==========================================
Files 643 643
Lines 181589 181588 -1
Branches 34883 34888 +5
==========================================
+ Hits 158072 158110 +38
+ Misses 16785 16750 -35
+ Partials 6732 6728 -4
|
trivikr
approved these changes
Aug 1, 2024
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54118 ✔ Done loading data for nodejs/node/pull/54118 ----------------------------------- PR info ------------------------------------ Title module: remove outdated comment (#54118) Author Michaël Zasso <[email protected]> (@targos) Branch targos:module-rm-comment -> nodejs:main Labels esm, author ready Commits 1 - module: remove outdated comment Committers 1 - Michaël Zasso <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54118 Refs: https://github.com/nodejs/node/pull/53822 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54118 Refs: https://github.com/nodejs/node/pull/53822 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 30 Jul 2024 10:13:09 GMT ✔ Approvals: 4 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/54118#pullrequestreview-2207278842 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/54118#pullrequestreview-2207294695 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54118#pullrequestreview-2208546573 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/54118#pullrequestreview-2211474577 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10196534245 |
|
Landed in 00c0644 |
targos
added a commit
that referenced
this pull request
Aug 14, 2024
Refs: #53822 PR-URL: #54118 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #53822