Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: explicit about VS 2015 support in readme #5406

Closed
wants to merge 1 commit into from

Conversation

phillipj
Copy link
Member

vcbuild.bat already supports both Visual Studio 2013 and 2015. Lets be explicit about it to avoid devs installing an old IDE.

@mscdex mscdex added doc Issues and PRs related to the documentations. windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Feb 24, 2016
@rvagg
Copy link
Member

rvagg commented Feb 24, 2016

Is the 2015 thing called "for Windows Desktop"?

@rvagg
Copy link
Member

rvagg commented Feb 24, 2016

@nodejs/platform-windows any input on clarifying exactly what's supported would be helpful

@phillipj
Copy link
Member Author

Is the 2015 thing called "for Windows Desktop"?

Yep. https://www.visualstudio.com/en-us/products/visual-studio-express-vs.aspx#scrum

@orangemocha
Copy link
Contributor

Visual Studio 2013 & 2015, all editions including the Community edition.
Visual Studio Express 2013 for Windows Desktop
Visual Studio Express 2015 for Desktop

@@ -160,8 +160,8 @@ $ node -e "console.log('Hello from Node.js ' + process.version)"
Prerequisites:

* [Python 2.6 or 2.7](https://www.python.org/downloads/)
* Visual Studio 2013 for Windows Desktop, or
* Visual Studio Express 2013 for Windows Desktop
* Visual Studio 2013 / 2015 for Windows Desktop, or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full edition doesn't have a "for Windows Desktop" SKU. Only the Visual Studio Express does and it was called "for Windows Desktop" in 2013 and "for Desktop" in 2015.

`vcbuild.bat` already supports both Visual Studio 2013 and 2015.
@phillipj
Copy link
Member Author

@orangemocha just pushed an updated.

Would you agree we can combine the express editions into one line of "for Desktop", rather than having two different lines just to get "for Windows Desktop" for VS Express 2013?

@orangemocha
Copy link
Contributor

Seems clear enough to me, but would like to get another +1.

LGTM

@rvagg
Copy link
Member

rvagg commented Feb 26, 2016

lgtm

@rvagg
Copy link
Member

rvagg commented Feb 26, 2016

landed @ 1d7c370, thanks @phillipj!

@rvagg rvagg closed this Feb 26, 2016
rvagg pushed a commit that referenced this pull request Feb 26, 2016
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
5 tasks
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
`vcbuild.bat` already supports both Visual Studio 2013 and 2015.

PR-URL: #5406
Reviewed-By: Alexis Campailla <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants