Fixes: https://github.com/nodejs/node/issues/53989

[EarlyRiser42]

Description

This pull request addresses an issue in the test suite where directory name comparisons on Windows are case-insensitive. The error occurs because Windows does not distinguish between uppercase and lowercase folder names. To handle this, I modified the function to compare directory names without considering case on Windows.

Code Change

The specific change made is as follows:

child.on('close', common.mustCall(function() {
  if (expectData) {
    // In Windows, compare without considering case
    if (process.platform === 'win32') {
      assert.strictEqual(data.trim().toLowerCase(), expectData.toLowerCase());
    } else {
      assert.strictEqual(data.trim(), expectData);
    }
  }
}));

Justification

This adjustment is intended to ensure that the comparison of directory names in Windows is case-insensitive, aligning with the operating system's handling of folder names. The function in question is limited to a specific test file, ensuring that the change does not impact other parts of the codebase.

While I believe this modification will resolve the issue, welcome any feedback or suggestions for improvement. If there are any further modifications or additional details required, please let me know. Thank you for considering this pull request.

Fixes: #53989

[jasnell]

nit: The commit message here does not match our commit guidelines and would need to be fixed before landing

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60549/

[github-actions]

Fast-track has been requested by @lpinca. Please 👍 to approve.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/53993
✔  Done loading data for nodejs/node/pull/53993
----------------------------------- PR info ------------------------------------
Title      Fixes: https://github.com/nodejs/node/issues/53989 (#53993)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     EarlyRiser42:issue-53889-bug-fix -> nodejs:main
Labels     test, fast-track, author ready, needs-ci, commit-queue-squash
Commits    2
 - test: compare paths on Windows without considering case
 - test: replace process.platform check with common.isWindows
Committers 1
 - EarlyRiser42 <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/53993
Fixes: https://github.com/nodejs/node/issues/53989
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53993
Fixes: https://github.com/nodejs/node/issues/53989
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 22 Jul 2024 14:04:11 GMT
   ✔  Approvals: 4
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53993#pullrequestreview-2191800289
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53993#pullrequestreview-2191805663
   ✔  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/53993#pullrequestreview-2192848228
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/53993#pullrequestreview-2192872913
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 31 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-07-23T02:30:10Z: https://ci.nodejs.org/job/node-test-pull-request/60549/
- Querying data for job/node-test-pull-request/60549/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/10053592803

[nodejs-github-bot]

Landed in 1eac9a3