timers: test timeout NaN warning in promises version #53622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingr
added
the
semver-major
nodejs-github-bot
added
needs-ci
debadree25
approved these changes
Jun 28, 2024
|
weird the CI bot is not here yet 🤔 Edit: ah CI is in lockdown missed the PSA oops |
legendecas
approved these changes
Jun 28, 2024
Co-authored-by: Chengzhong Wu <[email protected]>
aduh95
approved these changes
Jun 29, 2024
aduh95
added
author ready
|
The subsystem should be |
lpinca
approved these changes
Jun 29, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jul 4, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Landed in 2591638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, #46678 landed adding a warning when NaN is passed to timers. I noticed a test was missing for timers/promises there (the code works on both paths) - rather than holding that PR I figured we'd land it and I'd PR a test for timers/promises in a separate PR.
cc @jakecastelli
Refs: #46678