-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add more information to Makefile help #53381
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53381 +/- ##
==========================================
- Coverage 88.23% 87.70% -0.53%
==========================================
Files 652 652
Lines 183911 183911
Branches 35858 35562 -296
==========================================
- Hits 162271 161298 -973
- Misses 14916 15853 +937
- Partials 6724 6760 +36 |
Hey, I don't think this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
±0. In any case, some of the added verbs are in imperative form, some are in third-person singular present tense. I think these should at least be consistent within the same PR.
Commit Queue failed- Loading data for nodejs/node/pull/53381 ✔ Done loading data for nodejs/node/pull/53381 ----------------------------------- PR info ------------------------------------ Title build: add more information to Makefile help (#53381) Author Aviv Keller <[email protected]> (@RedYetiDev) Branch RedYetiDev:patch-55 -> nodejs:main Labels build, needs-ci, commit-queue-squash Commits 6 - build: add more information to Makefile help - Update Makefile - Update Makefile - fixup! periods + dependencies - reword valgrind tests - Merge branch 'main' into patch-55 Committers 2 - GitHub <[email protected]> - RedYetiDev <[email protected]> PR-URL: https://github.com/nodejs/node/pull/53381 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53381 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 07 Jun 2024 14:37:00 GMT ✔ Approvals: 2 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/53381#pullrequestreview-2263230673 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53381#pullrequestreview-2263779108 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10694556571 |
CI failed to start, it seems it was due to a merge conflict, I'll rebase |
Nevermind- it failed, I'm starting a new one |
681f41b
to
42523dc
Compare
I meant to add |
24c8b84
to
3dd8fe2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Looks like the most recent CI failed to start |
3dd8fe2
to
2897be9
Compare
CI is 🟢 / 🟠 (1 flake) |
CI is 🟢 (yay!) |
Landed in b2c42db |
PR-URL: #53381 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#53381 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: nodejs#53381 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This PR adds more information to the Makefile by adding more help details to more targets:
make help
output