[WIP] Fix ClangCL ARM64 cross-compilation #53003
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a WIP for fixing the ClangCL cross-compilation to ARM64. It consists of 2 dependency updates that should be done upstream and 1 change in Node.js itself to make everything work:
A fix in ICU a6932ad - To increase the chances of this landing upstream, the change is done by adding an option for this use case so it doesn't break any previously experienced behavior. After this is reviewed and discussed, I plan to open a PR in the ICU and try to land it there.
A fix in FP16 f8b52b5 - This already landed in the base repo. Since that project is a dependency of the V8, a CL to update it in V8 will be opened.
Node.js changes 176f1c6 - Once everything else is done, the change in the main repo is a simple one.
NOTE: Depending on the affected upstream projects and their release cycles and updates, we may need to use the patches on our side for some time.
cc @targos @lemire @nodejs/i18n-api
Refs: #52809