Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 12.4.254.17 #52980

Merged
merged 1 commit into from
May 18, 2024
Merged

deps: patch V8 to 12.4.254.17 #52980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 12
#define V8_MINOR_VERSION 4
#define V8_BUILD_NUMBER 254
#define V8_PATCH_LEVEL 14
#define V8_PATCH_LEVEL 17

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
34 changes: 17 additions & 17 deletions deps/v8/infra/testing/builders.pyl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,7 +962,7 @@
'v8_mac64_asan_rel': {
'swarming_dimensions' : {
'cpu': 'x86-64',
'os': 'Mac-13',
'os': 'Mac-14',
},
'tests': [
{'name': 'v8testing', 'shards': 8},
Expand All @@ -971,7 +971,7 @@
'v8_mac64_dbg': {
'swarming_dimensions' : {
'cpu': 'x86-64',
'os': 'Mac-13',
'os': 'Mac-14',
},
'tests': [
{'name': 'mozilla'},
Expand All @@ -984,7 +984,7 @@
'v8_mac_arm64_gc_stress_dbg': {
'swarming_dimensions' : {
'cpu': 'arm64',
'os': 'Mac-13',
'os': 'Mac-14',
},
'tests': [
{'name': 'd8testing', 'test_args': ['--gc-stress'], 'shards': 3},
Expand All @@ -993,7 +993,7 @@
'v8_mac64_noopt_dbg': {
'swarming_dimensions' : {
'cpu': 'x86-64',
'os': 'Mac-13',
'os': 'Mac-14',
},
'tests': [
{'name': 'v8testing', 'shards': 6},
Expand All @@ -1002,7 +1002,7 @@
'v8_mac64_rel': {
'swarming_dimensions' : {
'cpu': 'x86-64',
'os': 'Mac-13',
'os': 'Mac-14',
},
'tests': [
{'name': 'mozilla'},
Expand All @@ -1015,7 +1015,7 @@
'v8_mac_arm64_rel': {
'swarming_dimensions' : {
'cpu': 'arm64',
'os': 'Mac-13',
'os': 'Mac-14',
'pool': 'chromium.tests',
},
'tests': [
Expand All @@ -1031,7 +1031,7 @@
'v8_mac_arm64_dbg': {
'swarming_dimensions' : {
'cpu': 'arm64',
'os': 'Mac-13',
'os': 'Mac-14',
'pool': 'chromium.tests',
},
'tests': [
Expand All @@ -1047,7 +1047,7 @@
'v8_mac_arm64_full_dbg': {
'swarming_dimensions' : {
'cpu': 'arm64',
'os': 'Mac-13',
'os': 'Mac-14',
'pool': 'chromium.tests',
},
'tests': [
Expand All @@ -1063,7 +1063,7 @@
'v8_mac_arm64_no_pointer_compression_dbg': {
'swarming_dimensions' : {
'cpu': 'arm64',
'os': 'Mac-13',
'os': 'Mac-14',
'pool': 'chromium.tests',
},
'tests': [
Expand Down Expand Up @@ -1848,7 +1848,7 @@
'V8 Mac64': {
'swarming_dimensions': {
'cpu': 'x86-64',
'os': 'Mac-13',
'os': 'Mac-14',
},
'tests': [
{'name': 'mozilla'},
Expand All @@ -1861,7 +1861,7 @@
'V8 Mac64 - debug': {
'swarming_dimensions': {
'cpu': 'x86-64',
'os': 'Mac-13',
'os': 'Mac-14',
},
'tests': [
{'name': 'mozilla'},
Expand All @@ -1874,7 +1874,7 @@
'V8 Mac64 ASAN': {
'swarming_dimensions': {
'cpu': 'x86-64',
'os': 'Mac-13',
'os': 'Mac-14',
},
'tests': [
{'name': 'v8testing', 'shards': 10},
Expand All @@ -1883,15 +1883,15 @@
'V8 Mac - arm64 - gc stress': {
'swarming_dimensions': {
'cpu': 'arm64',
'os': 'Mac-13',
'os': 'Mac-14',
},
'tests': [
{'name': 'd8testing', 'test_args': ['--gc-stress'], 'shards': 3},
],
},
'V8 Mac - arm64': {
'swarming_dimensions' : {
'os': 'Mac-13',
'os': 'Mac-14',
'cpu': 'arm64',
'pool': 'chromium.tests',
},
Expand All @@ -1908,7 +1908,7 @@
},
'V8 Mac - arm64 - release': {
'swarming_dimensions' : {
'os': 'Mac-13',
'os': 'Mac-14',
'cpu': 'arm64',
'pool': 'chromium.tests',
},
Expand All @@ -1925,7 +1925,7 @@
},
'V8 Mac - arm64 - debug': {
'swarming_dimensions' : {
'os': 'Mac-13',
'os': 'Mac-14',
'cpu': 'arm64',
'pool': 'chromium.tests',
},
Expand All @@ -1943,7 +1943,7 @@
'V8 Mac - arm64 - no pointer compression debug': {
'swarming_dimensions' : {
'cpu': 'arm64',
'os': 'Mac-13',
'os': 'Mac-14',
'pool': 'chromium.tests',
},
'tests': [
Expand Down
8 changes: 8 additions & 0 deletions deps/v8/src/compiler/access-info.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,14 @@ PropertyAccessInfo AccessorAccessInfoHelper(
Cell::cast(module_namespace->module()->exports()->Lookup(
isolate, name.object(),
Smi::ToInt(Object::GetHash(*name.object())))));
if (IsAnyStore(access_mode)) {
// ES#sec-module-namespace-exotic-objects-set-p-v-receiver
// ES#sec-module-namespace-exotic-objects-defineownproperty-p-desc
//
// Storing to a module namespace object is always an error or a no-op in
// JS.
return PropertyAccessInfo::Invalid(zone);
}
if (IsTheHole(cell->value(kRelaxedLoad), isolate)) {
// This module has not been fully initialized yet.
return PropertyAccessInfo::Invalid(zone);
Expand Down
33 changes: 21 additions & 12 deletions deps/v8/src/maglev/maglev-graph-builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4001,19 +4001,28 @@ ReduceResult MaglevGraphBuilder::TryBuildPropertyStore(
access_info.holder().value());
}

if (access_info.IsFastAccessorConstant()) {
return TryBuildPropertySetterCall(access_info, receiver,
GetAccumulatorTagged());
} else {
DCHECK(access_info.IsDataField() || access_info.IsFastDataConstant());
ReduceResult res = TryBuildStoreField(access_info, receiver, access_mode);
if (res.IsDone()) {
RecordKnownProperty(receiver, name,
current_interpreter_frame_.accumulator(),
AccessInfoGuaranteedConst(access_info), access_mode);
return res;
switch (access_info.kind()) {
case compiler::PropertyAccessInfo::kFastAccessorConstant:
return TryBuildPropertySetterCall(access_info, receiver,
GetAccumulatorTagged());
case compiler::PropertyAccessInfo::kDataField:
case compiler::PropertyAccessInfo::kFastDataConstant: {
ReduceResult res = TryBuildStoreField(access_info, receiver, access_mode);
if (res.IsDone()) {
RecordKnownProperty(
receiver, name, current_interpreter_frame_.accumulator(),
AccessInfoGuaranteedConst(access_info), access_mode);
return res;
}
return ReduceResult::Fail();
}
return ReduceResult::Fail();
case compiler::PropertyAccessInfo::kInvalid:
case compiler::PropertyAccessInfo::kNotFound:
case compiler::PropertyAccessInfo::kDictionaryProtoDataConstant:
case compiler::PropertyAccessInfo::kDictionaryProtoAccessorConstant:
case compiler::PropertyAccessInfo::kModuleExport:
case compiler::PropertyAccessInfo::kStringLength:
UNREACHABLE();
}
}

Expand Down
4 changes: 1 addition & 3 deletions deps/v8/src/objects/js-objects.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,9 +432,7 @@ Maybe<bool> JSReceiver::SetOrCopyDataProperties(
Nothing<bool>());

if (!from->HasFastProperties() && target->HasFastProperties() &&
!IsJSGlobalProxy(*target)) {
// JSProxy is always in slow-mode.
DCHECK(!IsJSProxy(*target));
IsJSObject(*target) && !IsJSGlobalProxy(*target)) {
// Convert to slow properties if we're guaranteed to overflow the number of
// descriptors.
int source_length;
Expand Down