doc: update hljs with the latest styles #52911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
@ovflowd I know you and that team are updating the docs, just want to make sure this wouldn't break anything |
MoLow
approved these changes
May 9, 2024
RedYetiDev
added
the
author ready
aduh95
reviewed
May 10, 2024
RedYetiDev
removed
the
author ready
|
(removing author-ready, as @aduh95 left comments without approval) I've made the requested changes in regards to the semicolons. I don't think variables will be effective here, as these stylings are from |
|
Just a FYI we're moving away from Highlight.js very soon to Shiki, so I honestly would recommend you to avoid spending calories on any API Docs-related changes... in general, as all these styles will be discarded. |
ovflowd
approved these changes
May 13, 2024
ovflowd
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 29884d1 |
targos
pushed a commit
that referenced
this pull request
May 15, 2024
PR-URL: #52911 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #52911 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #52911 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #52911 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
EliphazBouye
pushed a commit
to EliphazBouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52911 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52911 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Claudio Wunder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the hljs.css styling to use the latest styles (from the VSCode theme builtin to Highlight.js)
Dark:
Light: