-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mitigate flaky test-debug-no-context #5269
Conversation
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: nodejs#5268 Fixes: nodejs#4343
Stress test showing current version of test is flaky on win10: 15 failures in 100 runs Stress test showing the version in this PR is not flaky on win10: 0 failures in 100 runs Output showing the version in this PR fails as expected with Node.js 5.3.0:
Output showing the version in this PR passes as expected with Node.js 5.4.0:
|
LGTM |
@jasnell Actually, it is relevant. My mistake not labeling it. I've added |
Thank you! :-) |
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: nodejs#5268 Fixes: nodejs#4343 PR-URL: nodejs#5269 Reviewed-By: James M Snell <[email protected]>
Landed in c4b5a45 |
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: nodejs#5269
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: #5269 PR-URL: #5317 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <[email protected]>
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: #5269 PR-URL: #5317 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <[email protected]>
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: #5269 PR-URL: #5317 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <[email protected]>
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: #5269 PR-URL: #5317 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
Change test so that it passes on the occasional win10 access violation. The workaround here can be undone when issue 5268 is resolved. The test still detects the defect it was written to detect. There are two assertions that detect the defect and only one was disabled. Ref: #5268 Fixes: #4343 PR-URL: #5269 Reviewed-By: James M Snell <[email protected]>
test-debug-no-context flakiness was worked around in issue 5269 but the flaky designation was left for the test. This change removes it. Refs: #5269 PR-URL: #5317 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
Change test so that it passes on the occasional win10 access violation.
The workaround here can be undone when issue 5268 is resolved.
The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.
Ref: #5268
Fixes: #4343
/cc @bnoordhuis