-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add info on contributor spotlight program #52598
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs/TSC#1474 Signed-off-by: Michael Dawson <[email protected]>
Review requested:
|
anonrig
approved these changes
Apr 19, 2024
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
@VoltrexKeyva thanks for the suggested changes, accepted them all. |
ShogunPanda
approved these changes
Apr 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Amazing idea!
marco-ippolito
approved these changes
Apr 20, 2024
ruyadorno
approved these changes
Apr 20, 2024
MoLow
approved these changes
Apr 21, 2024
RafaelGSS
approved these changes
Apr 21, 2024
jasnell
approved these changes
Apr 21, 2024
jasnell
pushed a commit
that referenced
this pull request
Apr 21, 2024
Refs: nodejs/TSC#1474 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #52598 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in 44f81a1" |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
Refs: nodejs/TSC#1474 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #52598 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
Refs: nodejs/TSC#1474 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #52598 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
Refs: nodejs/TSC#1474 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #52598 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/TSC#1474