Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,src: remove --experimental-policy #52583

Merged
merged 4 commits into from
May 7, 2024
Merged

lib,src: remove --experimental-policy #52583

merged 4 commits into from
May 7, 2024

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Apr 18, 2024 •
edited
Loading

Refs: #52575

Summary: We are dropping the --experimental-policy feature from Node.js.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/security-wg
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 18, 2024
anonrig
anonrig approved these changes Apr 18, 2024
View reviewed changes
lib/internal/modules/run_main.js Outdated Show resolved Hide resolved
benjamingr
benjamingr reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally in favor of this PR, we should probably warn people against using it in the meantime in a smaller semver-ptch PR

@richardlau
Copy link
Member

Generally in favor of this PR, we should probably warn people against using it in the meantime in a smaller semver-ptch PR

We should doc deprecate it immediately -- even if it's not a requirement for experimental features to go through a full deprecation cycle the earlier we inform users that the feature is going away the better.

@MoLow MoLow added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Apr 19, 2024
@MoLow
Copy link
Member

MoLow commented Apr 19, 2024

added to tsc-agenda Issues and PRs to discuss during the meetings of the TSC. just for awareness

@RafaelGSS RafaelGSS force-pushed the drop-experimental-policy branch 3 times, most recently from e0004d1 to f4a190e Compare April 19, 2024 19:24
@RafaelGSS RafaelGSS marked this pull request as ready for review April 19, 2024 19:24
@RafaelGSS RafaelGSS added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v21.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Apr 19, 2024
@RafaelGSS
Copy link
Member Author

This is now ready to review. I'm adding the dont-land labels as requested by @richardlau to follow the deprecation cycle. So, here's the plan:

  • I'll open a new PR to update the doc to doc-deprecated
  • Merge that PR
  • Land doc-deprecation in all release lines
  • Merge this PR
  • Land this PR in all release lines

@RafaelGSS RafaelGSS mentioned this pull request Apr 19, 2024
Closed
@GeoffreyBooth
Copy link
Member

I’m adding the dont-land labels as requested by @richardlau to follow the deprecation cycle. So, here’s the plan:

I thought we never deprecated experimental features?

Ideally we would land this as part of 22.0.0.

@GeoffreyBooth GeoffreyBooth removed the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Apr 19, 2024
@richardlau
Copy link
Member

I’m adding the dont-land labels as requested by @richardlau to follow the deprecation cycle. So, here’s the plan:

I thought we never deprecated experimental features?

Ideally we would land this as part of 22.0.0.

We have in the past: #12243
I don't believe it is a requirement for experimental features to go through a full deprecation cycle, but that doesn't stop us doc-deprecating things. For example, I'd be much more hesitant to backport this PR (with 89 touched files) to LTS immediately -- I'd probably want to wait longer than the usual "two weeks in current" policy just due to the number of files touched whereas I'd have no issue with landing doc deprecations in line with the two week policy.

@GeoffreyBooth
Copy link
Member

I think it's less disruptive to remove this as part of 22.0.0 than later in the 22 line, or in 23.

@RedYetiDev
Copy link
Member

This is more of a meta note, but if we remove the experimental policy, we should also remove the issue label (policy) as well.

@joyeecheung
Copy link
Member

joyeecheung commented Apr 20, 2024 •
edited
Loading

Can we fast-track a doc-deprecation in 22? Maybe changing the experimental warning into deprecation warning too if that's not too much hassle? Then we can proceed with this PR for later versions of 22, or 23.

EDIT: oh I see #52602 now

@mhdawson mhdawson mentioned this pull request Apr 22, 2024
Closed
@RafaelGSS
Copy link
Member Author

doc-deprecation has been merged. I will wait for it to land on v22/v21 then I will proceed with this PR as it will hard conflict if I just merge it with dont-land-*.

@github-actions github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/8976580157

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58994/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59003/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59006/

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels May 7, 2024
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2024
@nodejs-github-bot nodejs-github-bot merged commit 951af83 into nodejs:main May 7, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 951af83

@RedYetiDev
Copy link
Member

The policy label should also be removed from the issue tracker

@RafaelGSS RafaelGSS mentioned this pull request May 7, 2024
Closed
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@RafaelGSS
lib,src: remove --experimental-policy
9005b4f 
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: nodejs#52583
Refs: nodejs#52575
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
targos pushed a commit that referenced this pull request May 8, 2024
@RafaelGSS @targos
lib,src: remove --experimental-policy
9a7ae9b 
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #52583
Refs: #52575
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
targos added a commit that referenced this pull request May 13, 2024
@targos
2024-05-14, Version 22.2.0 (Current)
f8eb8d9 
Notable changes:

doc:
  * add pimterry to collaborators (Tim Perry) #52874
lib,src:
  * remove --experimental-policy (Rafael Gonzaga) #52583
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung) #52692

PR-URL: TODO
targos added a commit that referenced this pull request May 13, 2024
@targos
2024-05-14, Version 22.2.0 (Current)
7d92816 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    #52766
doc:
  * add pimterry to collaborators (Tim Perry)
    #52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) #52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    #52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    #52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) #51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    #52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    #52692

PR-URL: #52971
@targos targos mentioned this pull request May 13, 2024
Merged
targos added a commit that referenced this pull request May 15, 2024
@targos
2024-05-15, Version 22.2.0 (Current)
d57af10 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    #52766
doc:
  * add pimterry to collaborators (Tim Perry)
    #52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) #52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    #52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    #52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) #51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    #52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    #52692

PR-URL: #52971
targos added a commit that referenced this pull request May 15, 2024
@targos
2024-05-15, Version 22.2.0 (Current)
28b0a58 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    #52766
doc:
  * add pimterry to collaborators (Tim Perry)
    #52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) #52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    #52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    #52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) #51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    #52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    #52692

PR-URL: #52971
@marco-ippolito
Copy link
Member

Do we want to backport it to v20?

@RafaelGSS
Copy link
Member Author

Do we want to backport it to v20?

Yes

EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
@RafaelGSS @EliphazBouye
lib,src: remove --experimental-policy
ca1fadb 
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: nodejs#52583
Refs: nodejs#52575
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
@targos @EliphazBouye
2024-05-15, Version 22.2.0 (Current)
eccd98f 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    nodejs#52766
doc:
  * add pimterry to collaborators (Tim Perry)
    nodejs#52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) nodejs#52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    nodejs#52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    nodejs#52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) nodejs#51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    nodejs#52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    nodejs#52692

PR-URL: nodejs#52971
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@RafaelGSS @bmeck
lib,src: remove --experimental-policy
62fc1f5 
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: nodejs#52583
Refs: nodejs#52575
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@targos @bmeck
2024-05-15, Version 22.2.0 (Current)
99e317e 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    nodejs#52766
doc:
  * add pimterry to collaborators (Tim Perry)
    nodejs#52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) nodejs#52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    nodejs#52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    nodejs#52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) nodejs#51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    nodejs#52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    nodejs#52692

PR-URL: nodejs#52971
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Jul 19, 2024
@RafaelGSS RafaelGSS mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@joyeecheung joyeecheung joyeecheung left review comments

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@MoLow MoLow MoLow approved these changes

@anonrig anonrig anonrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. experimental Issues and PRs related to experimental features. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. policy Issues and PRs related to the policy subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.