Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update minimatch index path #52523

Merged
merged 1 commit into from
Apr 15, 2024
Merged

tools: update minimatch index path #52523

merged 1 commit into from
Apr 15, 2024

Conversation

marco-ippolito
Copy link
Member

Fixes: #52520

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 14, 2024
targos
targos approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you tested the script locally.

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Apr 14, 2024 •
edited
Loading

LGTM assuming you tested the script locally.

yes 😄 I could give it a run with the action
RUN: https://github.com/nodejs/node/actions/runs/8679232857/job/23797550354 ✅
PR created: #52524

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 15, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 15, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0debfa4 into nodejs:main Apr 15, 2024
29 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0debfa4

aduh95 pushed a commit that referenced this pull request Apr 29, 2024
@marco-ippolito @aduh95
tools: update minimatch index path
15c5686 
PR-URL: #52523
Fixes: #52520
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@aduh95 aduh95 mentioned this pull request Apr 30, 2024
Merged
marco-ippolito added a commit that referenced this pull request May 2, 2024
@marco-ippolito
tools: update minimatch index path
babb6f9 
PR-URL: #52523
Fixes: #52520
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito added a commit that referenced this pull request May 3, 2024
@marco-ippolito
tools: update minimatch index path
c681336 
PR-URL: #52523
Fixes: #52520
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minimatch dep update fails
7 participants
@marco-ippolito @nodejs-github-bot @benjamingr @lpinca @targos @gireeshpunathil @MoLow