Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: run test-ubsan on ubuntu-latest #52375

Merged
merged 1 commit into from
Apr 5, 2024
Merged

tools: run test-ubsan on ubuntu-latest #52375

merged 1 commit into from
Apr 5, 2024

Conversation

targos
Copy link
Member

@targos targos commented Apr 5, 2024

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 5, 2024
@targos targos added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 5, 2024
@targos
Copy link
Member Author

targos commented Apr 5, 2024

Looks good.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Fast-track has been requested by @targos. Please 👍 to approve.

@targos
Copy link
Member Author

targos commented Apr 5, 2024

Good news: this run took 3h0m, while previous ones were all around 3h20m.

@targos targos mentioned this pull request Apr 5, 2024
Closed
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit 67b9dda into nodejs:main Apr 5, 2024
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 67b9dda

@targos targos deleted the test-ubsan-latest branch April 5, 2024 19:48
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@targos @marco-ippolito
tools: run test-ubsan on ubuntu-latest
d103956 
PR-URL: #52375
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@targos @marco-ippolito
tools: run test-ubsan on ubuntu-latest
e3e0c68 
PR-URL: #52375
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @lpinca @anonrig @RafaelGSS @marco-ippolito