Revert "deps: sync with upstream c-ares/c-ares@4ef6817" #5234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not having much luck starting a node-test-pull-request job, the page times out. Have to step out for a bit, will revisit when I'm back. Tests pass locally, FWIW. |
mscdex
added
c++
|
@bnoordhuis there is no staging to target. Is the plan to land this on 5.x and then cherry-pick onto master? |
No, just land on v5.x. Master isn't (known) broken at the moment, I'm just being cautious with v5.x. |
|
LGTM |
This reverts commit 35c3832. See [0] and [1] for background. Let's hold off on upgrading c-ares until upstream makes an official release. [0] nodejs#5185 [1] nodejs#5199 PR-URL: nodejs#5199 Reviewed-By: Fedor Indutny <[email protected]>
bnoordhuis
force-pushed
the
revert-cares-upgrade
branch
from
dd21eb4
to
127dd62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 35c3832.
See [0] and [1] for background. Let's hold off on upgrading c-ares
until upstream makes an official release.
[0] #5185
[1] #5199
R=@indutny
Aside: there isn't a v5.x-staging branch to target?