Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: implement parse method for safer URL parsing #52280

Merged
merged 4 commits into from
Apr 13, 2024
Merged

url: implement parse method for safer URL parsing #52280

merged 4 commits into from
Apr 13, 2024

Commits on Mar 30, 2024

  1. url: implement parse method for safer URL parsing 

    Implement the static parse method as per the WHATWG URL specification.
Unlike the URL constructor, URL.parse does not throw on invalid input,
instead returning null. This behavior allows safer parsing of URLs
without the need for try-catch blocks around constructor calls. The
implementation follows the steps outlined in the WHATWG URL standard,
ensuring compatibility and consistency with web platform URL parsing
APIs.

Fixes: nodejs#52208
Refs: whatwg/url#825
    @thisalihassan
    thisalihassan committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    808a77b View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. url: change approach for parse method

    @thisalihassan
    thisalihassan committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    b28fc6e View commit details
    Browse the repository at this point in the history

  2. url: fix lint

    @thisalihassan
    thisalihassan committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    48e3b9a View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. url: resolve feedback

    @thisalihassan
    thisalihassan committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c304252 View commit details
    Browse the repository at this point in the history