net: remove unused var self = this from old code
#5224
Conversation
|
LGTM |
|
This is proposed in #5231 as well |
|
Hey, I can't see the CI results. Assuming it passed - anything preventing a merge? |
|
Windows has a compilation failure. Weird cc @nodejs/ci |
cc @joaocgreis could it be an environment issue on that machine? See http://www.lenholgate.com/blog/2015/07/the-real-solution-to-error-msb4175-the-task-factory-codetaskfactory-could-not-be-loaded-from-the-ass.html |
|
I'm in favor of #5231 over this PR (sorry), as it tackles more issues which are all good to have. Best not to create a potential merge conflict and just go with that imho. |
|
@ronkorving I have no commitment to this code - it is merely a small contribution. To be honest - I'm not sure why it hasn't been merged yet. It doesn't conflict with that one or anything. |
|
Ah yeah, if they're equal, no point in letting it linger. Same at this point may be said for that other PR. Wish I could merge :) |
Removed an unused `var self = this` that is no longer required. PR-URL: nodejs#5224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
Landed in e6bfe04 |
Removed an unused `var self = this` that is no longer required. PR-URL: #5224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Removed an unused `var self = this` that is no longer required. PR-URL: #5224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
|
@jasnell lts? |
|
+1 |
Removed an unused `var self = this` that is no longer required. PR-URL: #5224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Removed an unused `var self = this` that is no longer required. PR-URL: #5224 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This method has an unused
var self = this.Unless I'm missing something obvious here it's redundant.