Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix cluster handle leak #5152

Closed
wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Feb 9, 2016

It is possible to cause a resource leak in SharedHandle. This commit fixes the leak.

This is a backport of da21dba to v0.12 plus the latest version of the test (which was updated since the original commit).

It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: nodejs#2510
PR-URL: nodejs#3510
Reviewed-By: Ben Noordhuis <[email protected]>
@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. v0.12 labels Feb 9, 2016
@bnoordhuis
Copy link
Member

LGTM

@jasnell
Copy link
Member

jasnell commented Feb 10, 2016

LGTM
@nodejs/lts

mscdex pushed a commit that referenced this pull request Feb 11, 2016
It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: #2510
PR-URL: #5152
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mscdex
Copy link
Contributor Author

mscdex commented Feb 11, 2016

Landed in 5f58ead.

@mscdex mscdex closed this Feb 11, 2016
@mscdex mscdex deleted the v0.12-backport-3510 branch February 11, 2016 18:04
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: #2510
PR-URL: #5152
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
It is possible to cause a resource leak in SharedHandle. This commit
fixes the leak.

Fixes: nodejs/node#2510
PR-URL: nodejs/node#5152
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants