-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update simdjson to 3.6.3 #51104
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dependencies
Pull requests that update a dependency file.
needs-ci
PRs that need a full CI run.
labels
Dec 10, 2023
@marco-ippolito we may need to run a step in the updater to run the formatter so the linter does not complain. |
This comment was marked as outdated.
This comment was marked as outdated.
So actually there is an issue with the maintaining dependencies script, there was a typo, that's why its failing |
marco-ippolito
approved these changes
Dec 16, 2023
aduh95
force-pushed
the
actions/tools-update-simdjson
branch
from
December 17, 2023 00:32
949c587
to
f9aaf46
Compare
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Dec 17, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 17, 2023
UlisesGascon
approved these changes
Dec 17, 2023
aduh95
force-pushed
the
actions/tools-update-simdjson
branch
from
December 19, 2023 10:08
f9aaf46
to
f731246
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 19, 2023
mhdawson
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mhdawson
pushed a commit
that referenced
this pull request
Dec 20, 2023
PR-URL: #51104 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Landed in e7d90c5 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #51104 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
marco-ippolito
added
the
backport-blocked-v20.x
PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport.
label
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-blocked-v20.x
PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport.
dependencies
Pull requests that update a dependency file.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of simdjson to 3.6.3.