Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: update iterations in benchmark/util/splice-one.js #50935

Closed
wants to merge 1 commit into from

Conversation

lucshi
Copy link

@lucshi lucshi commented Nov 27, 2023

Fixes: #50571

Belowing are the score improvement after 10X iteration change:
util/splice-one.js n=1000000
util/splice-one.js size=10 pos="start" n=1000000 percent=238.22%
util/splice-one.js size=100 pos="start" n=1000000 percent=115.14%
util/splice-one.js size=10 pos="middle" n=1000000 percent=320.22%
util/splice-one.js size=100 pos="middle" n=1000000 percent=130.79%
util/splice-one.js size=10 pos="end" n=1000000 percent=380.13%
util/splice-one.js size=100 pos="end" n=1000000 percent=371.70%
util/splice-one.js size=500 pos="end" n=1000000 percent=373.86%

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Nov 27, 2023
@lucshi
Copy link
Author

lucshi commented Nov 28, 2023

close this due to duplicated with #50698

@lucshi lucshi closed this Nov 28, 2023
@lucshi lucshi deleted the util/splice-one.js branch November 28, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The performance gap between node16 and node21 changes as the n of the benchmark changes
2 participants