meta: clarify nomination process according to Node.js charter #50834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
the
meta
gireeshpunathil
approved these changes
Nov 21, 2023
Co-authored-by: Gireesh Punathil <[email protected]>
|
I don't see how that comment led to this. And this language feels harsh; mentioning directly that the TSC might overrule an objection feels like it would chill people making objections. Doesn't the TSC already have this power without needing to add this text? |
|
Yes. Apparently a few other TSC members think it is required to explicit it out. |
RafaelGSS
approved these changes
Nov 21, 2023
ronag
approved these changes
Nov 21, 2023
mhdawson
reviewed
Nov 21, 2023
Co-authored-by: Michael Dawson <[email protected]>
anonrig
approved these changes
Nov 21, 2023
aduh95
approved these changes
Nov 21, 2023
joyeecheung
approved these changes
Nov 21, 2023
benjamingr
approved these changes
Nov 21, 2023
lpinca
approved these changes
Nov 21, 2023
RaisinTen
approved these changes
Nov 22, 2023
aduh95
reviewed
Nov 22, 2023
Co-authored-by: Antoine du Hamel <[email protected]>
targos
approved these changes
Nov 22, 2023
legendecas
approved these changes
Nov 22, 2023
github-actions
bot
removed
the
request-ci
This comment was marked as off-topic.
This comment was marked as off-topic.
jasnell
reviewed
Nov 24, 2023
| the nomination fails. | ||
| The nomination passes if no collaborators oppose it after one week. In the case | ||
| of an objection, the TSC is responsible for working with the individuals | ||
| involved and finding a resolution. |
There was a problem hiding this comment.
Suggested change
| involved and finding a resolution. | |
| involved and finding a resolution. The TSC may, at its discretion, vote to override | |
| any objection but should do so only after other measures to reach consensus have | |
| failed. |
There was a problem hiding this comment.
I prefer the existing phrasing since it says the TSC is responsible for resolving the matter rather than just voting. The TSC for example can come to consensus about overriding a nomination without voting. It also emphasizes the TSC working with the individuals rather than them having to reach consensus on their own.
jasnell
approved these changes
Nov 24, 2023
ruyadorno
approved these changes
Nov 24, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50834 ✔ Done loading data for nodejs/node/pull/50834 ----------------------------------- PR info ------------------------------------ Title meta: clarify nomination process according to Node.js charter (#50834) Author Matteo Collina (@mcollina) Branch mcollina:clarify-nomination-process -> nodejs:main Labels meta Commits 4 - meta: clarify nomination process according to Node.js charter - Update GOVERNANCE.md - Update GOVERNANCE.md - Update GOVERNANCE.md Committers 2 - Matteo Collina - GitHub PR-URL: https://github.com/nodejs/node/pull/50834 Reviewed-By: Gireesh Punathil Reviewed-By: Rafael Gonzaga Reviewed-By: Robert Nagy Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Michael Dawson Reviewed-By: Joyee Cheung Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Michaël Zasso Reviewed-By: Chengzhong Wu Reviewed-By: James M Snell Reviewed-By: Ruy Adorno ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50834 Reviewed-By: Gireesh Punathil Reviewed-By: Rafael Gonzaga Reviewed-By: Robert Nagy Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Michael Dawson Reviewed-By: Joyee Cheung Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Michaël Zasso Reviewed-By: Chengzhong Wu Reviewed-By: James M Snell Reviewed-By: Ruy Adorno -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 21 Nov 2023 08:59:46 GMT ✔ Approvals: 14 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1741455492 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742081465 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742112546 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742210875 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742213614 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742224874 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742622759 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742635069 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743060178 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743672722 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743943202 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743957631 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1748043163 ✔ - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1748302024 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50834 From https://github.com/nodejs/node * branch refs/pull/50834/merge -> FETCH_HEAD ✔ Fetched commits as ed5cb37ccbc4..ea35554c7d75 -------------------------------------------------------------------------------- [main af5b57919e] meta: clarify nomination process according to Node.js charter Author: Matteo Collina Date: Tue Nov 21 09:59:10 2023 +0100 1 file changed, 3 insertions(+) [main f41d89451f] Update GOVERNANCE.md Author: Matteo Collina Date: Tue Nov 21 10:13:59 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main b03aacd5a2] Update GOVERNANCE.md Author: Matteo Collina Date: Tue Nov 21 15:42:33 2023 +0100 1 file changed, 3 insertions(+), 5 deletions(-) [main 6d64197199] Update GOVERNANCE.md Author: Matteo Collina Date: Wed Nov 22 10:35:08 2023 +0100 1 file changed, 3 insertions(+), 3 deletions(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)https://github.com/nodejs/node/actions/runs/6991191399 |
mcollina
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5f8ec99 |
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Nov 26, 2023
Signed-off-by: Matteo Collina <[email protected]> PR-URL: nodejs#50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Matteo Collina <[email protected]> PR-URL: nodejs#50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 29, 2023
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 30, 2023
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 19, 2023
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarification on the nomination process as mentioned by @jasnell in nodejs/TSC#1467 (comment).