Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for-of in test-url-relative #50788

Merged
merged 1 commit into from
Nov 21, 2023
Merged

test: replace forEach with for-of in test-url-relative #50788

merged 1 commit into from
Nov 21, 2023

Conversation

vitosorriso
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
Ethan-Arrowood
Ethan-Arrowood approved these changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - please make sure to run make lint-js

@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 18, 2023
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55785/

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit f425710 into nodejs:main Nov 21, 2023
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f425710

targos pushed a commit that referenced this pull request Nov 23, 2023
@vitosorriso @targos
test: replace forEach with for-of in test-url-relative
239d747 
PR-URL: #50788
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@vitosorriso @martenrichter
test: replace forEach with for-of in test-url-relative
6bea86e 
PR-URL: nodejs#50788
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@vitosorriso
test: replace forEach with for-of in test-url-relative
ecc8936 
PR-URL: nodejs#50788
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@vitosorriso @RafaelGSS
test: replace forEach with for-of in test-url-relative
82f0882 
PR-URL: #50788
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@vitosorriso @RafaelGSS
test: replace forEach with for-of in test-url-relative
40991d4 
PR-URL: #50788
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@vitosorriso @UlisesGascon
test: replace forEach with for-of in test-url-relative
12e9380 
PR-URL: #50788
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@vitosorriso @UlisesGascon
test: replace forEach with for-of in test-url-relative
0ed5f2a 
PR-URL: #50788
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@vitosorriso @UlisesGascon
test: replace forEach with for-of in test-url-relative
6410446 
PR-URL: #50788
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vitosorriso @nodejs-github-bot @jasnell @Ethan-Arrowood @marco-ippolito