lib: streamline process.binding() handling #50773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joyeecheung
commented
Nov 17, 2023
joyeecheung
commented
- Make processBindingAllowList a separate list from runtimeDeprecatedList and legacyWrapperList instead of being an umbrella one, so it's easier to see the stages the bindings are in.
- Cache process.binding() results so we don't need to mutate runtimeDeprecatedList.
- Make processBindingAllowList a separate list from runtimeDeprecatedList and legacyWrapperList instead of being an umbrella one, so it's easier to see the stages the bindings are in. - Cache process.binding() results so we don't need to mutate runtimeDeprecatedList.
|
Review requested:
|
nodejs-github-bot
added
lib / src
H4ad
approved these changes
Nov 17, 2023
jasnell
approved these changes
Nov 19, 2023
Co-authored-by: Vinicius Lourenço <[email protected]>
github-actions
bot
removed
the
request-ci
joyeecheung
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50773 ✔ Done loading data for nodejs/node/pull/50773 ----------------------------------- PR info ------------------------------------ Title lib: streamline process.binding() handling (#50773) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:binding-wrappers -> nodejs:main Labels lib / src, needs-ci, commit-queue-squash Commits 2 - lib: streamline process.binding() handling - fixup! lib: streamline process.binding() handling Committers 2 - Joyee Cheung - GitHub PR-URL: https://github.com/nodejs/node/pull/50773 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50773 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - fixup! lib: streamline process.binding() handling ℹ This PR was created on Fri, 17 Nov 2023 18:29:05 GMT ✔ Approvals: 2 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50773#pullrequestreview-1738093565 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50773#pullrequestreview-1738716129 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-11-25T14:32:09Z: https://ci.nodejs.org/job/node-test-pull-request/55910/ - Querying data for job/node-test-pull-request/55910/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7024794514 |
joyeecheung
added a commit
that referenced
this pull request
Nov 28, 2023
- Make processBindingAllowList a separate list from runtimeDeprecatedList and legacyWrapperList instead of being an umbrella one, so it's easier to see the stages the bindings are in. - Cache process.binding() results so we don't need to mutate runtimeDeprecatedList. PR-URL: #50773 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 940910d (with linter fix applied) |
targos
pushed a commit
that referenced
this pull request
Dec 4, 2023
- Make processBindingAllowList a separate list from runtimeDeprecatedList and legacyWrapperList instead of being an umbrella one, so it's easier to see the stages the bindings are in. - Cache process.binding() results so we don't need to mutate runtimeDeprecatedList. PR-URL: #50773 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
- Make processBindingAllowList a separate list from runtimeDeprecatedList and legacyWrapperList instead of being an umbrella one, so it's easier to see the stages the bindings are in. - Cache process.binding() results so we don't need to mutate runtimeDeprecatedList. PR-URL: #50773 Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.