Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: avoid copying strings in FSPermission::Apply #50662

Merged
merged 1 commit into from
Nov 19, 2023
Merged

src: avoid copying strings in FSPermission::Apply #50662

merged 1 commit into from
Nov 19, 2023

Commits on Nov 17, 2023

  1. src: avoid copying strings in FSPermission::Apply 

    The use of string_view and subsequent copying to a string was supposed
to be a minor optimization in 640a7918, however, since 413c16e, no
string splitting occurs anymore. Therefore, we can simply pass around
some references instead of using string_view or copying strings.

Refs: nodejs#48491
Refs: nodejs#49047
    @tniessen
    tniessen committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    2ee82d5 View commit details
    Browse the repository at this point in the history