src: handle errors from uv_pipe_connect2() #50657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to handle errors from uv_pipe_connect2() because return type is `int`. Fixes: nodejs#50652 Refs: nodejs#49667 Refs: libuv/libuv#4030
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Nov 10, 2023
github-actions
bot
removed
the
request-ci
27 tasks
jasnell
approved these changes
Nov 11, 2023
18 tasks
theanarkh
approved these changes
Nov 12, 2023
theanarkh
added
the
author ready
deokjinkim
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9134f4a |
This was referenced Nov 13, 2023
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
We need to handle errors from uv_pipe_connect2() because return type is `int`. Fixes: #50652 Refs: #49667 Refs: libuv/libuv#4030 PR-URL: #50657 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: theanarkh <[email protected]>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
We need to handle errors from uv_pipe_connect2() because return type is `int`. Fixes: #50652 Refs: #49667 Refs: libuv/libuv#4030 PR-URL: #50657 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: theanarkh <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to handle errors from uv_pipe_connect2()
because return type is
int.Fixes: #50652
Refs: #49667
Refs: libuv/libuv#4030
@bnoordhuis I didn't find caller of
PipeWrap::Connectyet. Can I get some hint?