Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,stream: enable compression WPTs #50631

Closed
wants to merge 2 commits into from
Closed

test,stream: enable compression WPTs #50631

wants to merge 2 commits into from

Conversation

panva
Copy link
Member

@panva panva commented Nov 8, 2023 •
edited
Loading

A followup to #50097

  • Enables the compression WPTs with the JSON status file reflecting the current status of the API in Node.js
  • Fixes the constructor handling of the format argument to follow its WebIDL definition

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Nov 8, 2023
@panva panva added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. stream Issues and PRs related to the stream subsystem. web streams needs-ci PRs that need a full CI run. and removed needs-ci PRs that need a full CI run. web streams labels Nov 8, 2023
@panva panva changed the title streams: add deflate-raw to De/CompressionStream stream: add deflate-raw to De/CompressionStream Nov 8, 2023
@panva panva added the experimental Issues and PRs related to experimental features. label Nov 8, 2023
@panva panva marked this pull request as ready for review November 8, 2023 23:21
@panva panva added semver-minor PRs that contain new features and should be released in the next minor version. request-ci Add this label to start a Jenkins CI on a PR. and removed experimental Issues and PRs related to experimental features. labels Nov 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva
Copy link
Member Author

panva commented Nov 9, 2023 •
edited
Loading

I didn't notice #50097, I'll push that over the line and turn this into just a PR enabling the WPTs to run and a couple small fixes.

@panva panva added test Issues and PRs related to the tests. and removed commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. semver-minor PRs that contain new features and should be released in the next minor version. labels Nov 9, 2023
@panva panva changed the title stream: add deflate-raw to De/CompressionStream test,stream: add compression tests to the WPT test suite Nov 9, 2023
@panva panva marked this pull request as draft November 9, 2023 10:39
@panva panva changed the title test,stream: add compression tests to the WPT test suite test,stream: add compression WPTs Nov 9, 2023
@panva panva changed the title test,stream: add compression WPTs test,stream: enable compression WPTs Nov 9, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023
@panva
Copy link
Member Author

panva commented Nov 9, 2023

cc @nodejs/web-standards @nodejs/streams

I'll also open a separate issue to document the failing or skipped WPTs so that they may be investigated and subsequently possibly fixed by someone with deeper knowledge of the subsystem.

@panva panva added the web-standards Issues and PRs related to Web APIs label Nov 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva mentioned this pull request Nov 9, 2023
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55526/

@panva
Copy link
Member Author

panva commented Nov 9, 2023 •
edited
Loading

preview: https://staging.wpt.fyi/results/compression?q=.any.html&run_id=6063987856769024&run_id=5143837821370368&run_id=4967230276108288

This was referenced Nov 10, 2023
Open
Open
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 11, 2023
@github-actions github-actions bot mentioned this pull request Nov 12, 2023
Open
18 tasks
mcollina
mcollina approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 314c8f9...9d652f4

nodejs-github-bot pushed a commit that referenced this pull request Nov 12, 2023
@panva @nodejs-github-bot
test,stream: enable compression WPTs
635a5c8 
PR-URL: #50631
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Nov 12, 2023
@panva @nodejs-github-bot
stream: treat compression web stream format per its WebIDL definition
9d652f4 
PR-URL: #50631
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@panva panva deleted the compression-wpt branch November 12, 2023 10:02
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Open
24 tasks
@panva panva mentioned this pull request Nov 13, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva @targos
test,stream: enable compression WPTs
7ebc8c2 
PR-URL: #50631
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva @targos
stream: treat compression web stream format per its WebIDL definition
146ad9c 
PR-URL: #50631
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
@panva panva added backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. labels Dec 15, 2023
@panva
Copy link
Member Author

panva commented Dec 15, 2023 •
edited
Loading

Backport blocked until #50097 is also backported.

@panva panva mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. web streams web-standards Issues and PRs related to Web APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @mcollina @jasnell